Skip to content

Fix duplicate mission fetching, show loading notification when fetchi…#712

Merged
1Blademaster merged 5 commits intorelease-alpha-0.1.10from
alpha-0.1.10/711-add-an-indicator-on-dashboard-when-all-mission-is-being-read
Sep 23, 2025
Merged

Fix duplicate mission fetching, show loading notification when fetchi…#712
1Blademaster merged 5 commits intorelease-alpha-0.1.10from
alpha-0.1.10/711-add-an-indicator-on-dashboard-when-all-mission-is-being-read

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

…ng mission on dashboard

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes duplicate mission fetching and adds loading notifications when fetching missions on the dashboard. The key changes optimize mission data retrieval and improve user experience by showing loading states.

Key changes:

  • Simplifies error handling in mission controller by removing warning logs for failed mission item fetches
  • Adds dashboard-specific mission fetching control to prevent unnecessary duplicate requests
  • Implements loading notifications to provide user feedback during mission fetch operations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
radio/app/controllers/missionController.py Simplified error handling by removing warning logs for failed mission fetches
gcs/src/redux/slices/missionSlice.js Added state management for dashboard mission fetching control and loading notifications
gcs/src/redux/middleware/socketMiddleware.js Updated connection handling to manage dashboard mission fetch flag
gcs/src/redux/middleware/emitters.js Added loading notification trigger when emitting mission fetch requests
gcs/src/helpers/notification.js Added utility functions for loading notifications with update capability
gcs/src/components/layout.jsx Implemented conditional mission fetching based on dashboard state flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread radio/app/controllers/missionController.py
Comment thread radio/app/controllers/missionController.py
Comment thread radio/app/controllers/missionController.py
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we'd want more "loading" notifications around. They seem like a good indicator - for example we could have a loading notification for when you connect to a drone and click off the modal as right now it just works in the background. Nothing related to this ticket tho.

@1Blademaster 1Blademaster merged commit 3861968 into release-alpha-0.1.10 Sep 23, 2025
7 checks passed
@1Blademaster 1Blademaster deleted the alpha-0.1.10/711-add-an-indicator-on-dashboard-when-all-mission-is-being-read branch September 23, 2025 17:54
1Blademaster added a commit that referenced this pull request Sep 28, 2025
#712)

* Fix duplicate mission fetching, show loading notification when fetching mission on dashboard

* Display errors on getCurrentMissionAll

* Fix test

* Fix merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants