Alpha 0.1.10/701 fix reboot functionality#702
Merged
1Blademaster merged 6 commits intorelease-alpha-0.1.10from Sep 19, 2025
Merged
Alpha 0.1.10/701 fix reboot functionality#7021Blademaster merged 6 commits intorelease-alpha-0.1.10from
1Blademaster merged 6 commits intorelease-alpha-0.1.10from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes reboot functionality for the autopilot system by addressing several issues in the reboot process and improving the overall robustness of drone reconnection.
- Enables previously skipped test for reboot functionality
- Improves reboot process with proper cleanup and state management
- Enhances parameter retrieval with timeout handling and better error logging
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/tests/test_autopilot.py | Re-enables skipped test for reboot functionality |
| radio/app/endpoints/autopilot.py | Improves reboot process with cleanup, state management, and enhanced reconnection logic |
| radio/app/drone.py | Adds port and baud information to debug logging |
| radio/app/controllers/paramsController.py | Enhances parameter retrieval with proper timeout handling and message filtering |
| radio/app.py | Minor code organization cleanup |
| gcs/src/redux/slices/droneConnectionSlice.js | Adds state management functionality |
| gcs/src/redux/middleware/socketMiddleware.js | Improves connection handling and state synchronization |
| gcs/src/redux/middleware/emitters.js | Fixes state emission to update Redux state |
| gcs/src/params.jsx | Fixes component structure by moving modal outside conditional rendering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
suggested changes
Sep 19, 2025
NexInfinite
approved these changes
Sep 19, 2025
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Fix reboot connection and modal * Fix params not being fetched after reboot * Remove console.logs * Fix mypy issue. address copilot review comments * Fix tests * Make changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.