Publish heartbeat message every second#693
Merged
1Blademaster merged 5 commits intorelease-alpha-0.1.10from Sep 14, 2025
Merged
Publish heartbeat message every second#6931Blademaster merged 5 commits intorelease-alpha-0.1.10from
1Blademaster merged 5 commits intorelease-alpha-0.1.10from
Conversation
…use Event, fixed closing threads
1Blademaster
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the drone connection management system by changing the is_active variable from a boolean to a threading Event object, adds a heartbeat message functionality, and improves thread lifecycle management.
- Replaced
is_activeboolean with threading Event for better thread synchronization - Added heartbeat message sending every second to maintain drone communication
- Implemented proper thread cleanup with timeout-based queue operations and centralized thread stopping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| radio/app/endpoints/autopilot.py | Updated to use Event's is_set() method instead of direct boolean check |
| radio/app/drone.py | Major refactoring to use Event for thread management, added heartbeat functionality, improved queue handling with timeouts, and centralized thread cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Publish heartbeat message every second, update is_active variable to use Event, fixed closing threads * Add timeout to join threads * Fix mypy error * Fix mypy issues * Fix mypy issue again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and update is_active variable to use threading Event, fixed closing threads