Add input to set loiter radius#678
Merged
1Blademaster merged 6 commits intorelease-alpha-0.1.10from Sep 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to set and retrieve the loiter radius parameter for drone navigation. The implementation provides both backend API endpoints and frontend UI components to manage the loiter radius setting.
- Adds new socket endpoints for getting and setting loiter radius values
- Implements frontend input component for users to modify loiter radius
- Updates Redux state management to track loiter radius data
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/nav.py | Adds socket endpoints for getting/setting loiter radius with validation |
| radio/app/controllers/paramsController.py | Adds debugging print statement and timing delay |
| radio/app/controllers/navController.py | Implements loiter radius get/set methods using WP_LOITER_RAD parameter |
| radio/app/controllers/missionController.py | Repositions is_listening flag assignment for better control flow |
| gcs/src/redux/slices/droneInfoSlice.js | Adds loiter radius state management and actions |
| gcs/src/redux/slices/droneConnectionSlice.js | Adds emitter for getting loiter radius |
| gcs/src/redux/middleware/socketMiddleware.js | Handles socket events for loiter radius operations |
| gcs/src/redux/middleware/emitters.js | Implements socket emission for loiter radius requests |
| gcs/src/components/layout.jsx | Triggers loiter radius fetch on dashboard load |
| gcs/src/components/dashboard/tabsSectionTabs/actionTabsSection.jsx | Adds UI component for setting loiter radius |
| gcs/src/components/dashboard/tabsSection.jsx | Passes loiter radius data to action tabs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
reviewed
Sep 9, 2025
NexInfinite
reviewed
Sep 9, 2025
NexInfinite
approved these changes
Sep 9, 2025
Contributor
NexInfinite
left a comment
NexInfinite
left a comment
There was a problem hiding this comment.
LGTM, I've cleaned up the styling here
1Blademaster
deleted the
alpha-0.1.10/509-add-action-to-set-loiter-radius
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Add input to set loiter radius * Address copilot review comments * Fix mypy issues * aligned inputs * formatted * cleaned up comment --------- Co-authored-by: Julian Jones <julianjones663@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is not always functional as there is a bug with getSingleParam not fetching the parameter properly (https://github.com/orgs/Avis-Drone-Labs/projects/10/views/1?pane=issue&itemId=127953840)