Alpha 0.1.10/553 add logging on frontend and backend#652
Closed
Jopat2409 wants to merge 77 commits intorelease-alpha-0.1.10from
Closed
Alpha 0.1.10/553 add logging on frontend and backend#652Jopat2409 wants to merge 77 commits intorelease-alpha-0.1.10from
Jopat2409 wants to merge 77 commits intorelease-alpha-0.1.10from
Conversation
…electron anyways)
…Labs/FGCS into alpha-0.1.10/553-add-logging-on-frontend-and-backend
…Labs/FGCS into alpha-0.1.10/553-add-logging-on-frontend-and-backend
… reducer is dispatched, not in it
Contributor
Author
|
Christ nevermind |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…https://github.com/Avis-Drone-Labs/FGCS into alpha-0.1.10/553-add-logging-on-frontend-and-backend
…-on-frontend-and-backend
1Blademaster
requested changes
Sep 6, 2025
Comment on lines
+64
to
+69
| "logToWorkingDirectory": { | ||
| "description": "Log files will be placed in gcs/logs instead of appdata/FGCS/logs", | ||
| "display": "Log to Development Workspace", | ||
| "type": "boolean", | ||
| "default": false | ||
| }, |
Member
There was a problem hiding this comment.
Instead of making this a setting, can we check if it's a development environment and log to gcs/logs, if it's prod then use default log location?
…Labs/FGCS into alpha-0.1.10/553-add-logging-on-frontend-and-backend
Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
…https://github.com/Avis-Drone-Labs/FGCS into alpha-0.1.10/553-add-logging-on-frontend-and-backend
Member
|
This has become very stale, closing this PR. |
1Blademaster
deleted the
alpha-0.1.10/553-add-logging-on-frontend-and-backend
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description because this is a fairly big one, feel free to disagree with any of this and request it be changed
Centralised Logging
Logging is all done through the electron process because it means we can have a centralised configuration for both frontend, backend and any other logging sources that we might end up adding at some point, and knowing from when I tried to do the ticket off alpha-0.1.9, trying to configure the python logging to be the same as the log4js logging was annoying. It also means that we have access to all application logs on the frontend, which is good if we ever want to implement some sort of log viewing from within the application itself (or want to access most recent logs to display in the error boundary perhaps, anything like that)
Backend logs are just passed through the socket connection to the socket handler in redux and then we just have a basic loggingSlice that keeps a short history of the logs and dispatches handlers which can consume the logs however they like (currently we have 1 for passing the logs to the electron process and one for console logging them).
Default Configuration
Default configuration for the packaged application
Developer Settings
Added developer settings - special settings tab that's only available in development environment, allows us to have an actual way of configuring development settings without development configs etc.
Added a couple of settings for changing logging behaviour in development to make it easier (though maybe we can have it enablable in build, I know a lot of applications allow you to toggle developer options if you really want to)