Skip to content

Fix bugs with home location and waypoints not being displayed correctly#635

Merged
1Blademaster merged 1 commit intorelease-alpha-0.1.10from
alpha-0.1.10/634-moving-home-location-bug
Aug 22, 2025
Merged

Fix bugs with home location and waypoints not being displayed correctly#635
1Blademaster merged 1 commit intorelease-alpha-0.1.10from
alpha-0.1.10/634-moving-home-location-bug

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster requested a review from Copilot August 20, 2025 02:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes bugs related to the display of home location and waypoints in a mission management system. The changes address issues with incorrect sequence numbering, filtering of mission items, and improve the handling of home commands in both Python controller code and JavaScript frontend components.

Key changes:

  • Fixed off-by-one errors in mission item sequence numbering across Python logging and JavaScript UI
  • Replaced hardcoded filtering logic with a reusable isGlobalFrameHomeCommand function
  • Removed unused Redux selector and simplified mission item filtering

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
radio/app/controllers/missionController.py Fixed sequence numbering in logging messages to use 1-based indexing
gcs/src/redux/slices/missionSlice.js Removed unused Redux selector for filtered mission items
gcs/src/helpers/filterMissions.js Refactored filtering logic to use dedicated home command detection
gcs/src/components/missions/*.jsx Updated table components to use seq property instead of array index
gcs/src/components/mapComponents/missionItems.jsx Fixed text display for mission item sequence numbers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread gcs/src/helpers/filterMissions.js
Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1Blademaster 1Blademaster merged commit 2274cf6 into release-alpha-0.1.10 Aug 22, 2025
7 checks passed
@1Blademaster 1Blademaster deleted the alpha-0.1.10/634-moving-home-location-bug branch August 22, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants