redux fix for alerts#632
Merged
bensgilbert merged 5 commits intorelease-alpha-0.1.10from Aug 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves altitude alert functionality from the main dashboard component to the status bar component, cleaning up the codebase by removing commented-out code and implementing the alert system using Redux state management.
- Removes commented-out altitude alert code from dashboard.jsx
- Implements altitude alert functionality in statusBar.jsx using Redux state
- Reorganizes imports to improve code structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gcs/src/dashboard.jsx | Removes commented-out alert code and reorganizes imports |
| gcs/src/components/dashboard/statusBar.jsx | Implements altitude alert functionality using Redux state |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
additionally improve number input in settings
1Blademaster
approved these changes
Aug 20, 2025
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* redux fix for alerts * add min and max altitudes additionally improve number input in settings * optimise altitude alert effect * ensure min altitude alerts are properly initialised --------- Co-authored-by: Kush Makkapati <kush.makkapati@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #623