Skip to content

Add mission import and export tests#630

Merged
1Blademaster merged 2 commits intorelease-alpha-0.1.10from
alpha-0.1.10/626-add-tests-for-importing-and-export-mission-files
Aug 22, 2025
Merged

Add mission import and export tests#630
1Blademaster merged 2 commits intorelease-alpha-0.1.10from
alpha-0.1.10/626-add-tests-for-importing-and-export-mission-files

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster requested a review from Copilot August 19, 2025 16:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive test coverage for mission import and export functionality. The changes include tests for importing missions from files, exporting missions to files, and error handling scenarios for both operations.

  • Adds new test fixtures for cleanup of exported files
  • Implements import tests for mission, fence, and rally types with success and error scenarios
  • Implements export tests for mission, fence, and rally types with file validation
  • Updates existing upload tests to verify roundtrip read-back functionality

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
radio/tests/test_mission.py Adds comprehensive test coverage for mission import/export operations and updates existing upload tests
radio/tests/mission_test_files/test_importMissionFromFile_*_result.json Test data files containing expected results for import operations
radio/tests/mission_test_files/exported_*_check.txt Reference files for validating export operations
radio/app/endpoints/mission.py Updates import message handling to use dynamic message from result
radio/app/controllers/missionController.py Improves error messages by using mission name instead of type number

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread radio/tests/test_mission.py
Comment thread radio/tests/test_mission.py
Comment thread radio/tests/test_mission.py
Comment thread radio/tests/test_mission.py
Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1Blademaster 1Blademaster merged commit 21a9822 into release-alpha-0.1.10 Aug 22, 2025
7 checks passed
@1Blademaster 1Blademaster deleted the alpha-0.1.10/626-add-tests-for-importing-and-export-mission-files branch August 22, 2025 14:15
1Blademaster added a commit that referenced this pull request Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants