Dashboard.jsx change for redux#617
Merged
NexInfinite merged 18 commits intorelease-alpha-0.1.10from Aug 18, 2025
Merged
Conversation
1Blademaster
previously approved these changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements Redux state management throughout the dashboard component, replacing local state management with centralized Redux stores. The changes migrate from component-level state to Redux slices for drone telemetry, mission data, and connection status management.
Key changes:
- Replaces local state with Redux selectors and actions across dashboard components
- Updates socket event handling to dispatch Redux actions instead of setting local state
- Modifies data flow from prop drilling to Redux-based state selection
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/subscribers/localStorageSubscriber.js | Uncomments store subscription logic for localStorage persistence |
| gcs/src/redux/slices/statusTextSlice.js | Changes message ordering from push to unshift |
| gcs/src/redux/slices/missionSlice.js | Updates property names from camelCase to snake_case and adds undefined checks |
| gcs/src/redux/slices/droneInfoSlice.js | Adds new selectors, updates property access patterns, and removes commented code |
| gcs/src/redux/slices/droneConnectionSlice.js | Updates socket emission calls and console messages |
| gcs/src/redux/middleware/socketMiddleware.js | Adds new socket event handlers and updates message processing logic |
| gcs/src/dashboard.jsx | Major refactor replacing local state with Redux selectors and actions |
| gcs/src/components/dashboard/*.jsx | Updates components to use Redux selectors instead of props |
| gcs/src/components/layout.jsx | Adds Redux integration for page state management |
| gcs/src/main.jsx | Wraps application with Redux Provider |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1Blademaster
approved these changes
Aug 18, 2025
Member
1Blademaster
left a comment
There was a problem hiding this comment.
Let's hope this works smoothly 😅
…-redux-conversion-file
Contributor
Author
|
FUCK IT WE BALL |
1Blademaster
pushed a commit
that referenced
this pull request
Aug 19, 2025
* Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes
1Blademaster
added a commit
that referenced
this pull request
Aug 19, 2025
…ut not written to the drone yet (#629) * Attempt to add warning for unwritten changes * Add mission tests (#616) * Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments * Dashboard.jsx change for redux (#617) * Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes * Fix activeTab state not updating bug (#625) * Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file * Attempt to add warning for unwritten changes * Remove unused code * Remove mission_type from write_mission_result * Fix equality comparision statements --------- Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
1Blademaster
pushed a commit
that referenced
this pull request
Sep 28, 2025
* Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
…ut not written to the drone yet (#629) * Attempt to add warning for unwritten changes * Add mission tests (#616) * Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments * Dashboard.jsx change for redux (#617) * Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes * Fix activeTab state not updating bug (#625) * Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file * Attempt to add warning for unwritten changes * Remove unused code * Remove mission_type from write_mission_result * Fix equality comparision statements --------- Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITS TIME TO REDUX!!!