Skip to content

Add mission tests#616

Merged
1Blademaster merged 7 commits intorelease-alpha-0.1.10from
alpha-0.1.10/611-add-mission-tests
Aug 18, 2025
Merged

Add mission tests#616
1Blademaster merged 7 commits intorelease-alpha-0.1.10from
alpha-0.1.10/611-add-mission-tests

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster changed the title Clean up mission tests Add mission tests Aug 17, 2025
@1Blademaster 1Blademaster marked this pull request as ready for review August 17, 2025 20:38
@1Blademaster 1Blademaster requested a review from Copilot August 17, 2025 20:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive mission testing functionality with new test files, fixtures, and test data. The changes focus on testing mission upload/download functionality for different mission types (mission, fence, rally) and improving test reliability by using file-based test data instead of hardcoded values.

  • Adds a new upload_default_mission pytest fixture to set up test data
  • Replaces hardcoded test data with JSON files for better maintainability
  • Adds comprehensive tests for individual mission type handling (mission, fence, rally)
  • Includes a new MissionController unit test file with tests for private methods

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
radio/tests/test_mission.py Refactored existing tests and added new tests for individual mission types with file-based test data
radio/tests/test_MissionController.py Added unit tests for MissionController private methods
radio/tests/mission_test_files/upload_mission_helper.py Added helper function for uploading missions during test setup
radio/tests/mission_test_files/*.json Added JSON files containing expected test results and input data
radio/tests/mission_test_files/*.txt Added mission files in QGC format for test setup
radio/app/controllers/missionController.py Fixed mission upload logic to handle MISSION_ACK messages properly
gcs/src/components/missions/missionStatistics.jsx Added optional chaining to prevent undefined access errors

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread radio/tests/mission_test_files/upload_mission_helper.py
Comment thread radio/tests/test_mission.py
@1Blademaster 1Blademaster merged commit 98df64e into release-alpha-0.1.10 Aug 18, 2025
7 checks passed
@1Blademaster 1Blademaster deleted the alpha-0.1.10/611-add-mission-tests branch August 18, 2025 19:44
1Blademaster added a commit that referenced this pull request Aug 19, 2025
* Clean up mission tests

* Fix bug with max slope gradient in missionStatistics

* Add tests for getting specific missions

* Add upload mission tests

* Add unit tests for MissionController functionality

* Address copilot review comments
1Blademaster added a commit that referenced this pull request Aug 19, 2025
…ut not written to the drone yet (#629)

* Attempt to add warning for unwritten changes

* Add mission tests (#616)

* Clean up mission tests

* Fix bug with max slope gradient in missionStatistics

* Add tests for getting specific missions

* Add upload mission tests

* Add unit tests for MissionController functionality

* Address copilot review comments

* Dashboard.jsx change for redux (#617)

* Fixed store, setup sockets, and started on dashboard

* Dashboard basically done

* Fixed map and refactored

* Cleaned up code and fixed mission items

* Fixes

* fixed linting

* AI Fixes

* Moved gps out and fixed messages - more to move still

* Updated messages

* More moving of variables/cleaning up

* Moved more things around :D

* formatted D:

* Fixed drone connection issues and states

* formatted

* FIXED IT WOOO

* formatted

* Kush fixes

* Fix activeTab state not updating bug (#625)

* Fix activeTab state not updating bug

* Move getFrameName function into dataFormatters file

* Attempt to add warning for unwritten changes

* Remove unused code

* Remove mission_type from write_mission_result

* Fix equality comparision statements

---------

Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
1Blademaster added a commit that referenced this pull request Sep 28, 2025
* Clean up mission tests

* Fix bug with max slope gradient in missionStatistics

* Add tests for getting specific missions

* Add upload mission tests

* Add unit tests for MissionController functionality

* Address copilot review comments
1Blademaster added a commit that referenced this pull request Sep 28, 2025
…ut not written to the drone yet (#629)

* Attempt to add warning for unwritten changes

* Add mission tests (#616)

* Clean up mission tests

* Fix bug with max slope gradient in missionStatistics

* Add tests for getting specific missions

* Add upload mission tests

* Add unit tests for MissionController functionality

* Address copilot review comments

* Dashboard.jsx change for redux (#617)

* Fixed store, setup sockets, and started on dashboard

* Dashboard basically done

* Fixed map and refactored

* Cleaned up code and fixed mission items

* Fixes

* fixed linting

* AI Fixes

* Moved gps out and fixed messages - more to move still

* Updated messages

* More moving of variables/cleaning up

* Moved more things around :D

* formatted D:

* Fixed drone connection issues and states

* formatted

* FIXED IT WOOO

* formatted

* Kush fixes

* Fix activeTab state not updating bug (#625)

* Fix activeTab state not updating bug

* Move getFrameName function into dataFormatters file

* Attempt to add warning for unwritten changes

* Remove unused code

* Remove mission_type from write_mission_result

* Fix equality comparision statements

---------

Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants