Add mission tests#616
Merged
1Blademaster merged 7 commits intorelease-alpha-0.1.10from Aug 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive mission testing functionality with new test files, fixtures, and test data. The changes focus on testing mission upload/download functionality for different mission types (mission, fence, rally) and improving test reliability by using file-based test data instead of hardcoded values.
- Adds a new
upload_default_missionpytest fixture to set up test data - Replaces hardcoded test data with JSON files for better maintainability
- Adds comprehensive tests for individual mission type handling (mission, fence, rally)
- Includes a new
MissionControllerunit test file with tests for private methods
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/tests/test_mission.py | Refactored existing tests and added new tests for individual mission types with file-based test data |
| radio/tests/test_MissionController.py | Added unit tests for MissionController private methods |
| radio/tests/mission_test_files/upload_mission_helper.py | Added helper function for uploading missions during test setup |
| radio/tests/mission_test_files/*.json | Added JSON files containing expected test results and input data |
| radio/tests/mission_test_files/*.txt | Added mission files in QGC format for test setup |
| radio/app/controllers/missionController.py | Fixed mission upload logic to handle MISSION_ACK messages properly |
| gcs/src/components/missions/missionStatistics.jsx | Added optional chaining to prevent undefined access errors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Kwash67
approved these changes
Aug 18, 2025
1Blademaster
added a commit
that referenced
this pull request
Aug 19, 2025
* Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments
1Blademaster
added a commit
that referenced
this pull request
Aug 19, 2025
…ut not written to the drone yet (#629) * Attempt to add warning for unwritten changes * Add mission tests (#616) * Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments * Dashboard.jsx change for redux (#617) * Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes * Fix activeTab state not updating bug (#625) * Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file * Attempt to add warning for unwritten changes * Remove unused code * Remove mission_type from write_mission_result * Fix equality comparision statements --------- Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
…ut not written to the drone yet (#629) * Attempt to add warning for unwritten changes * Add mission tests (#616) * Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments * Dashboard.jsx change for redux (#617) * Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes * Fix activeTab state not updating bug (#625) * Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file * Attempt to add warning for unwritten changes * Remove unused code * Remove mission_type from write_mission_result * Fix equality comparision statements --------- Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.