Alpha 0.1.10/574 add fence functionality to missions#607
Merged
1Blademaster merged 10 commits intorelease-alpha-0.1.10from Aug 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive fence functionality to the missions system, allowing users to create, edit, and manage geofence items within the ground control station interface.
- Implements fence item creation with polygon and circle support
- Adds visual representation of fence items on the map with inclusion/exclusion coloring
- Creates dedicated UI components for fence item management
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/missions.jsx | Main file adding fence state management, polygon creation, and tab functionality |
| gcs/src/helpers/mavlinkConstants.js | Enables fence command constants by removing comments |
| gcs/src/components/missions/rallyItemsTable.jsx | Updates table headers to remove parameter labels |
| gcs/src/components/missions/missionsMap.jsx | Adds polygon drawing mode and fence visualization capabilities |
| gcs/src/components/missions/fenceItemsTableRow.jsx | New component for fence item table row with editing capabilities |
| gcs/src/components/missions/fenceItemsTable.jsx | New component for fence items table display |
| gcs/src/components/mapComponents/polygon.jsx | New component for polygon visualization on map |
| gcs/src/components/mapComponents/fenceItems.jsx | New component for fence item map visualization |
| gcs/src/components/mapComponents/drawLineCoordinates.jsx | Adds fill layer support for polygon visualization |
| gcs/src/components/mapComponents/contextMenuSubMenuItem.jsx | New component for nested context menu items |
| gcs/src/components/mapComponents/contextMenuItem.jsx | Updates styling to maintain consistent layout |
Comments suppressed due to low confidence (1)
gcs/src/missions.jsx:172
- This code is duplicated with lines 210-215. Consider extracting the fence items processing logic into a helper function to reduce duplication.
} else if (data.mission_type === "fence") {
1Blademaster
deleted the
alpha-0.1.10/574-add-fence-functionality-to-missions
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Start adding fence functionality to missions * Add circle fence marker display * Add context menu dropdown item * Start adding polygon drawing functionality * Add polygon update function * Style mission tabs to match marker pin colours * Add polygon display to missions map for fence polygons * Fix 2 bugs * Address copilot review comments * Fix bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.