Skip to content

Add progress modal for reading and writing mission to drone#606

Merged
NexInfinite merged 4 commits intorelease-alpha-0.1.10from
alpha-0.1.10/572-show-modal-while-reading-mission-from-drone
Aug 7, 2025
Merged

Add progress modal for reading and writing mission to drone#606
NexInfinite merged 4 commits intorelease-alpha-0.1.10from
alpha-0.1.10/572-show-modal-while-reading-mission-from-drone

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster requested a review from Copilot August 7, 2025 19:42
@1Blademaster 1Blademaster linked an issue Aug 7, 2025 that may be closed by this pull request

This comment was marked as outdated.

@1Blademaster 1Blademaster requested a review from Copilot August 7, 2025 19:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a progress modal to provide real-time feedback to users during drone mission reading and writing operations. The implementation includes progress callbacks on the backend and a modal dialog on the frontend to display progress updates.

  • Adds progress callback functionality to mission controller methods
  • Implements real-time progress updates via WebSocket events
  • Creates a modal dialog to display progress during mission operations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
radio/app/endpoints/mission.py Adds progress callback function and passes it to mission controller methods
radio/app/controllers/missionController.py Updates mission methods to accept and use progress callbacks with detailed progress reporting
gcs/src/missions.jsx Implements progress modal UI with progress bar and real-time updates

Comment thread radio/app/controllers/missionController.py Outdated
Comment thread radio/app/controllers/missionController.py
Comment thread radio/app/controllers/missionController.py
Copy link
Copy Markdown
Contributor

@NexInfinite NexInfinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NexInfinite NexInfinite merged commit 7ff8947 into release-alpha-0.1.10 Aug 7, 2025
7 checks passed
@NexInfinite NexInfinite deleted the alpha-0.1.10/572-show-modal-while-reading-mission-from-drone branch August 7, 2025 20:06
1Blademaster added a commit that referenced this pull request Sep 28, 2025
* Add progress modal for reading and writing mission to drone

* Fix default type for callback function in mission controller

* Address copilot review comments

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show modal while reading mission from drone

3 participants