Sync params between config page and params page#1115
Merged
1Blademaster merged 1 commit intoMar 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds param synchronization between the config workflow (flight mode / channel changes) and the params page state, so that when a config action writes a param, the params Redux slice stays up to date.
Changes:
- Add
data: { param_id, value }to successful flight mode / flight mode channel set responses in the radio backend. - Update radio backend tests to validate the new response payload shape.
- Update GCS socket middleware to mirror config-originated param changes into
paramsSliceviaupdateParamValue.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/controllers/flightModesController.py | Include param metadata in success responses to enable frontend syncing. |
| radio/app/endpoints/flightMode.py | No functional change; preserves emitting of controller result payload. |
| radio/tests/test_flightMode.py | Update endpoint socket tests to assert data payload. |
| radio/tests/test_FlightModesController.py | Update controller tests to assert data payload. |
| gcs/src/redux/middleware/socketMiddleware.js | Add helper(s) to sync config-set params into paramsSlice and wire into relevant socket events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.