Skip to content

Sync params between config page and params page#1115

Merged
1Blademaster merged 1 commit into
mainfrom
1025-bug-params-not-syncing-between-config-and-params-pages
Mar 22, 2026
Merged

Sync params between config page and params page#1115
1Blademaster merged 1 commit into
mainfrom
1025-bug-params-not-syncing-between-config-and-params-pages

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 22, 2026 21:27
@1Blademaster 1Blademaster linked an issue Mar 22, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds param synchronization between the config workflow (flight mode / channel changes) and the params page state, so that when a config action writes a param, the params Redux slice stays up to date.

Changes:

  • Add data: { param_id, value } to successful flight mode / flight mode channel set responses in the radio backend.
  • Update radio backend tests to validate the new response payload shape.
  • Update GCS socket middleware to mirror config-originated param changes into paramsSlice via updateParamValue.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
radio/app/controllers/flightModesController.py Include param metadata in success responses to enable frontend syncing.
radio/app/endpoints/flightMode.py No functional change; preserves emitting of controller result payload.
radio/tests/test_flightMode.py Update endpoint socket tests to assert data payload.
radio/tests/test_FlightModesController.py Update controller tests to assert data payload.
gcs/src/redux/middleware/socketMiddleware.js Add helper(s) to sync config-set params into paramsSlice and wire into relevant socket events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@1Blademaster 1Blademaster merged commit f910bd6 into main Mar 22, 2026
12 checks passed
@1Blademaster 1Blademaster deleted the 1025-bug-params-not-syncing-between-config-and-params-pages branch March 22, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Params not syncing between config and params pages

2 participants