Serial ports config page completed#1097
Merged
1Blademaster merged 14 commits intomainfrom Mar 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end Serial Ports configuration support (backend Socket.IO endpoints + drone controller + GCS UI/redux wiring) so operators can view and update SERIAL1–SERIAL7 settings from the Config screen.
Changes:
- Backend: introduce
SerialPortsControllerand Socket.IO endpoints for get/set/batch-set serial port params. - Frontend: add a new “Serial Ports” config tab with redux state, socket listeners, and emitters.
- Drone connection flow: instantiate the new controller during controller setup and add a new connection phase message.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/serialPorts.py | New Socket.IO handlers for serial ports config get/set/batch-set |
| radio/app/endpoints/init.py | Registers the new serialPorts endpoint module |
| radio/app/drone.py | Adds SerialPortsController to controller setup + new connection phase |
| radio/app/controllers/serialPortsController.py | New controller that reads/writes SERIAL1–7 params via ParamsController |
| gcs/src/redux/slices/configSlice.js | Adds serialPortsConfig state, reducers, selectors, and emit actions |
| gcs/src/redux/middleware/socketMiddleware.js | Adds socket listeners to receive/update serial ports config |
| gcs/src/redux/middleware/emitters.js | Adds emitters to request/set/batch-set serial ports config |
| gcs/src/config.jsx | Adds “Serial Ports” tab and panel to the Config page |
| gcs/src/components/config/serialPorts.jsx | New Serial Ports UI (table + selects + options bitmask) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
1Blademaster
requested changes
Mar 20, 2026
Member
1Blademaster
left a comment
There was a problem hiding this comment.
Please also add relevant tests for this.
1Blademaster
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.