Skip to content

Serial ports config page completed#1097

Merged
1Blademaster merged 14 commits intomainfrom
898-add-a-serial-ports-config-page
Mar 21, 2026
Merged

Serial ports config page completed#1097
1Blademaster merged 14 commits intomainfrom
898-add-a-serial-ports-config-page

Conversation

@Kwash67
Copy link
Copy Markdown
Contributor

@Kwash67 Kwash67 commented Mar 18, 2026

No description provided.

@Kwash67 Kwash67 requested review from a team and Copilot March 18, 2026 18:19
@Kwash67 Kwash67 linked an issue Mar 18, 2026 that may be closed by this pull request
@Kwash67 Kwash67 changed the title implementation complete for serial ports config page Serial ports config page completed Mar 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end Serial Ports configuration support (backend Socket.IO endpoints + drone controller + GCS UI/redux wiring) so operators can view and update SERIAL1–SERIAL7 settings from the Config screen.

Changes:

  • Backend: introduce SerialPortsController and Socket.IO endpoints for get/set/batch-set serial port params.
  • Frontend: add a new “Serial Ports” config tab with redux state, socket listeners, and emitters.
  • Drone connection flow: instantiate the new controller during controller setup and add a new connection phase message.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
radio/app/endpoints/serialPorts.py New Socket.IO handlers for serial ports config get/set/batch-set
radio/app/endpoints/init.py Registers the new serialPorts endpoint module
radio/app/drone.py Adds SerialPortsController to controller setup + new connection phase
radio/app/controllers/serialPortsController.py New controller that reads/writes SERIAL1–7 params via ParamsController
gcs/src/redux/slices/configSlice.js Adds serialPortsConfig state, reducers, selectors, and emit actions
gcs/src/redux/middleware/socketMiddleware.js Adds socket listeners to receive/update serial ports config
gcs/src/redux/middleware/emitters.js Adds emitters to request/set/batch-set serial ports config
gcs/src/config.jsx Adds “Serial Ports” tab and panel to the Config page
gcs/src/components/config/serialPorts.jsx New Serial Ports UI (table + selects + options bitmask)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread radio/app/drone.py
Comment thread radio/app/controllers/serialPortsController.py Outdated
Comment thread radio/app/controllers/serialPortsController.py
Comment thread gcs/src/components/config/serialPorts.jsx
Comment thread gcs/src/components/config/serialPorts.jsx
@1Blademaster
Copy link
Copy Markdown
Member

image image

Serial 5 doesn't exist on my FC, but Serial 8 does and that doesn't show up in the config page.

Copy link
Copy Markdown
Member

@1Blademaster 1Blademaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add relevant tests for this.

Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/components/config/serialPorts.jsx Outdated
Comment thread gcs/src/redux/middleware/emitters.js Outdated
Comment thread radio/app/controllers/serialPortsController.py Outdated
@1Blademaster 1Blademaster merged commit 5c68c0f into main Mar 21, 2026
8 checks passed
@1Blademaster 1Blademaster deleted the 898-add-a-serial-ports-config-page branch March 21, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a serial ports config page

3 participants