Skip to content

980 feature more detailed connecting modal#1046

Merged
Turnlings merged 6 commits intomainfrom
980-feature-more-detailed-connecting-modal
Mar 4, 2026
Merged

980 feature more detailed connecting modal#1046
Turnlings merged 6 commits intomainfrom
980-feature-more-detailed-connecting-modal

Conversation

@Turnlings
Copy link
Copy Markdown
Contributor

@Turnlings Turnlings commented Mar 4, 2026

Stream the param currently being fetched to the frontend using the current callback style architecture. (And show it when connecting)

image

@Turnlings Turnlings linked an issue Mar 4, 2026 that may be closed by this pull request
@Turnlings Turnlings marked this pull request as ready for review March 4, 2026 17:30
Copilot AI review requested due to automatic review settings March 4, 2026 17:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a backend→frontend socket event to surface the specific parameter currently being fetched, and displays it in the GCS connection progress modal to provide more detailed connection feedback.

Changes:

  • Add a new backend callback (fetchingParameterCb) that emits fetching_param over Socket.IO with the current parameter name.
  • Thread the callback through drone construction/reboot paths and invoke it when fetching single parameters.
  • Add Redux state + socket listener + UI rendering to show the currently fetched parameter while connecting.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
radio/app/utils.py Adds fetchingParameterCb Socket.IO emitter for the currently fetched param.
radio/app/endpoints/comPorts.py Passes fetchingParameterCb into Drone construction during connect.
radio/app/endpoints/autopilot.py Preserves and reuses fetchingParameterCb across autopilot reboot reconnect attempts.
radio/app/drone.py Stores the optional fetchingParameterCb callback on the Drone instance.
radio/app/controllers/paramsController.py Emits “currently fetching param” before param_request_read_send in getSingleParam.
gcs/src/redux/slices/paramsSlice.js Adds fetchingParam state + reducer + selector.
gcs/src/redux/middleware/socketMiddleware.js Listens for fetching_param socket event and dispatches setFetchingParam.
gcs/src/components/connectionProgress.jsx Displays “Fetching {param}” beneath the connection status message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/redux/slices/paramsSlice.js
Comment thread gcs/src/components/connectionProgress.jsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gcs/src/redux/slices/paramsSlice.js Outdated
Comment thread gcs/src/redux/middleware/socketMiddleware.js
@Turnlings Turnlings requested a review from a team March 4, 2026 18:16
@Turnlings Turnlings self-assigned this Mar 4, 2026
Comment thread radio/app/utils.py Outdated
@Turnlings Turnlings requested a review from 1Blademaster March 4, 2026 19:31
Copy link
Copy Markdown
Member

@1Blademaster 1Blademaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said on Discord I'm also not a fan of all this callback-hell, hopefully we can plan and refactor this in the future.

@Turnlings Turnlings merged commit ed0214a into main Mar 4, 2026
8 of 9 checks passed
@Turnlings Turnlings deleted the 980-feature-more-detailed-connecting-modal branch March 4, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] More detailed connecting modal

3 participants