980 feature more detailed connecting modal#1046
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a backend→frontend socket event to surface the specific parameter currently being fetched, and displays it in the GCS connection progress modal to provide more detailed connection feedback.
Changes:
- Add a new backend callback (
fetchingParameterCb) that emitsfetching_paramover Socket.IO with the current parameter name. - Thread the callback through drone construction/reboot paths and invoke it when fetching single parameters.
- Add Redux state + socket listener + UI rendering to show the currently fetched parameter while connecting.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/utils.py | Adds fetchingParameterCb Socket.IO emitter for the currently fetched param. |
| radio/app/endpoints/comPorts.py | Passes fetchingParameterCb into Drone construction during connect. |
| radio/app/endpoints/autopilot.py | Preserves and reuses fetchingParameterCb across autopilot reboot reconnect attempts. |
| radio/app/drone.py | Stores the optional fetchingParameterCb callback on the Drone instance. |
| radio/app/controllers/paramsController.py | Emits “currently fetching param” before param_request_read_send in getSingleParam. |
| gcs/src/redux/slices/paramsSlice.js | Adds fetchingParam state + reducer + selector. |
| gcs/src/redux/middleware/socketMiddleware.js | Listens for fetching_param socket event and dispatches setFetchingParam. |
| gcs/src/components/connectionProgress.jsx | Displays “Fetching {param}” beneath the connection status message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
left a comment
There was a problem hiding this comment.
As said on Discord I'm also not a fan of all this callback-hell, hopefully we can plan and refactor this in the future.
Stream the param currently being fetched to the frontend using the current callback style architecture. (And show it when connecting)