Skip to content

ESC Telemetry Dashboard Widget#1040

Merged
1Blademaster merged 26 commits intomainfrom
979-feature-have-a-dashboard-widget-for-esc-telemetry
Mar 25, 2026
Merged

ESC Telemetry Dashboard Widget#1040
1Blademaster merged 26 commits intomainfrom
979-feature-have-a-dashboard-widget-for-esc-telemetry

Conversation

@Matthew-Dobson
Copy link
Copy Markdown
Contributor

No description provided.

@Matthew-Dobson Matthew-Dobson self-assigned this Mar 2, 2026
@Matthew-Dobson Matthew-Dobson linked an issue Mar 2, 2026 that may be closed by this pull request
@Matthew-Dobson Matthew-Dobson changed the title added ESC to listeners WIP: ESC Telemetry Dashboard Widget Mar 2, 2026
@Matthew-Dobson Matthew-Dobson changed the title WIP: ESC Telemetry Dashboard Widget ESC Telemetry Dashboard Widget Mar 10, 2026
@Matthew-Dobson Matthew-Dobson marked this pull request as ready for review March 11, 2026 10:26
@Matthew-Dobson Matthew-Dobson requested review from a team and Copilot March 11, 2026 10:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an ESC telemetry dashboard widget and wires MAVLink ESC telemetry messages through the backend state listeners and the GCS Redux/socket pipeline so the dashboard can display ESC metrics alongside existing widgets.

Changes:

  • Subscribe the backend dashboard state to ESC_TELEMETRY_1_TO_4 and update the corresponding test expectation.
  • Extend GCS Redux state/selectors and socket middleware to store/aggregate ESC telemetry packets.
  • Add a new EscTelemetryWidget and adjust the dashboard layout to stack widgets at the bottom.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
yarn.lock Adds a Yarn v1 lockfile header at repo root.
node_modules/.yarn-integrity Adds Yarn integrity metadata file under root node_modules/.
radio/tests/test_states.py Updates expected listener count for dashboard state.
radio/app/endpoints/states.py Adds ESC_TELEMETRY_1_TO_4 to dashboard message listeners.
radio/app/endpoints/params.py Formats params_error emit payload into a one-liner.
gcs/src/redux/slices/droneInfoSlice.js Adds ESC telemetry state, reducers/selectors, and an aggregated selector.
gcs/src/redux/middleware/socketMiddleware.js Dispatches ESC telemetry messages into Redux on receipt.
gcs/src/dashboard.jsx Adds the ESC telemetry widget and groups bottom widgets in a stacked container.
gcs/src/components/dashboard/videoWidget.jsx Refactors positioning; widget now relies on parent container layout.
gcs/src/components/dashboard/EscTelemetryWidget.jsx Introduces the new ESC telemetry widget UI with threshold settings and resizing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread node_modules/.yarn-integrity Outdated
Comment thread gcs/src/components/dashboard/videoWidget.jsx
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/dashboard.jsx Outdated
Comment thread gcs/src/dashboard.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/components/dashboard/EscTelemetryWidget.jsx Outdated
Comment thread gcs/src/redux/slices/droneInfoSlice.js Outdated
@1Blademaster
Copy link
Copy Markdown
Member

1Blademaster commented Mar 15, 2026

If I click to expand ESC telemetry when connected and not connected I get an error.
image

@Matthew-Dobson
Copy link
Copy Markdown
Contributor Author

If I click to expand ESC telemetry when connected and not connected I get an error. image

I think i've fixed this, but also not too sure what you mean exactly, can you check again in next review pls :)

@1Blademaster
Copy link
Copy Markdown
Member

I feel like it looks a bit odd when resizing? Maybe let's just remove the resizing as it doesn't add that much I don't think.
image

Also when the values are updating constantly the widths of the boxes keep changing.

@1Blademaster
Copy link
Copy Markdown
Member

Also not sure why but the video select looks a bit odd now when ESC telem is resized.
image

@1Blademaster 1Blademaster merged commit 933527a into main Mar 25, 2026
8 checks passed
@1Blademaster 1Blademaster deleted the 979-feature-have-a-dashboard-widget-for-esc-telemetry branch March 25, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Have a dashboard widget for ESC telemetry

3 participants