Remove wireless option when connecting to a drone#1006
Merged
1Blademaster merged 2 commits intomainfrom Feb 25, 2026
Merged
Conversation
…dating data stream rates
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the “wireless connection” toggle from the GCS-to-backend connection flow and simplifies the backend Drone connection API accordingly, including consolidating MAVLink datastream rate configuration and updating docs.
Changes:
- Removed
wirelessfrom the socket payload/state (Redux slice, localStorage persistence, UI checkbox, and middleware emitters). - Updated backend connection endpoints and
Droneconstructor to drop thewirelessparameter and always use a single datastream-rate map. - Updated backend architecture documentation to reflect the new
Droneconstructor / datastream configuration.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/comPorts.py | Removes wireless from the connection payload type and from Drone(...) construction. |
| radio/app/endpoints/autopilot.py | Stops persisting/restoring a removed drone.wireless attribute across reboot reconnects. |
| radio/app/drone.py | Removes wireless argument/field and consolidates datastream rates into one constant. |
| gcs/src/redux/store.js | Removes wireless preference persistence and cleans up imports. |
| gcs/src/redux/slices/droneConnectionSlice.js | Removes wireless from Redux state/actions/selectors. |
| gcs/src/redux/middleware/socketMiddleware.js | Removes wireless from emitted connect payload (e.g., SITL/network connect). |
| gcs/src/components/navbar.jsx | Removes the wireless checkbox/UI and stops sending wireless in connect payload. |
| docs/BACKEND_ARCHITECTURE.md | Updates docs for new Drone signature and datastream-rate constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kwash67
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.