Exclude libc / libm / ld-linux from the tarball#496
Merged
AnarManafov merged 1 commit intoFairRootGroup:masterfrom Oct 8, 2025
Merged
Exclude libc / libm / ld-linux from the tarball#496AnarManafov merged 1 commit intoFairRootGroup:masterfrom
AnarManafov merged 1 commit intoFairRootGroup:masterfrom
Conversation
Contributor
Author
|
To believe me: will happily show that |
|
When I build DDS with this, then the agent fails to start with: And if I run it in lightweight mode, then not even the DDSWorker.sh gets shipped to the node and nothing can start. |
Contributor
Contributor
Author
|
@lkrcal Is this on top of master or 3.13? |
Contributor
Author
|
On my box I get: Which I think it's what's expected no? ldd also report what I would expect as libraries: |
Contributor
|
To me the patch makes perfect sense. What Lubos is getting is something else. I will check that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One cannot simply ship libc and ld-linux.so and hope they will be picked up correctly. In particular, ld-linux will always be the one of the system, because it gets loaded first by the kernel, when the executable is not yet around. This means that the current approach fails when the shipped libc is not compatible with the system ld-linux. It's much safer to simply not ship libc at all and pickup the system version.