test: prove unsigned contribution is rejected - #12
Closed
enoreyes wants to merge 1 commit into
Closed
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
Author
|
Validation complete: DCO / signoff rejected commit 2d1d1c7 with missing_dco_signoff and git commit --amend --signoff remediation; Metadata, Quality, CodeQL, and dependency review passed. This contribution is intentionally not merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DCO must reject a contribution whose newly introduced commit lacks a Signed-off-by trailer.
Scope
One harmless disposable Markdown file and one deliberately unsigned commit.
Non-goals
No merge, production change, ruleset change, protection weakening, or persistent branch.
Acceptance
DCO / signoff fails with missing_dco_signoff while all other applicable checks remain intact; this pull request is then closed and its branch deleted.
Validation
Inspect the DCO annotation for commit 2d1d1c7 and the stable remediation command git commit --amend --signoff.
Dependencies
Protected main merge 738bfd7 and active ruleset 21212019.
Risk
The branch contains no executable content and is never merged.
Rollout
Close without merge after observing the required failure, then delete the branch.
Observability
GitHub preserves the pull request and failed DCO check URL.
Documentation
The disposable file is test evidence only and will not reach main.
Compatibility
No compatibility impact.
Generated artifacts
None.
Agent authorship
Factory Droid created this authorized negative test under @enoreyes authority; the commit intentionally omits DCO signoff.