Skip to content

chore(ci): point module_register at facets-scripts#557

Open
anujhydrabadi wants to merge 1 commit into
masterfrom
chore/rename-facets-schemas-scripts-to-facets-scripts
Open

chore(ci): point module_register at facets-scripts#557
anujhydrabadi wants to merge 1 commit into
masterfrom
chore/rename-facets-schemas-scripts-to-facets-scripts

Conversation

@anujhydrabadi

@anujhydrabadi anujhydrabadi commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

What

Update the module_register.sh URL in the preview workflow from facets-schemas/scriptsfacets-scripts/scripts.

Why

facets-schemas is being retired (secret leaked in its git history). Its scripts/ folder — the only live, hand-maintained content — moved to the new public facets-scripts repo, served via GitHub Pages at https://facets-cloud.github.io/facets-scripts/scripts/. No behavior change; same scripts, new host path.

Part of a coordinated cross-repo migration.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated the preview deployment process to use the correct script source, helping module registration run reliably during previews.

Update the `module_register.sh` URL in the preview workflow from `facets-schemas/scripts` → `facets-scripts/scripts`.

Part of a coordinated migration retiring facets-schemas (secret leaked in its
git history). Scripts moved to the new public facets-scripts repo, served at
https://facets-cloud.github.io/facets-scripts/scripts/. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55ee3a83-bcd1-448a-a375-beef9bdca96a

📥 Commits

Reviewing files that changed from the base of the PR and between c6a285c and e09cc7f.

📒 Files selected for processing (1)
  • .github/workflows/preview.yml

Walkthrough

The GitHub Actions preview workflow's module registration step is updated to download module_register.sh from the facets-scripts repository path instead of facets-schemas. Script arguments remain unchanged.

Changes

Preview Workflow Update

Layer / File(s) Summary
Module registration script source
.github/workflows/preview.yml
The curl | bash command for module registration now fetches module_register.sh from facets-scripts/scripts/ instead of facets-schemas/scripts/.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and rationale, but it omits most template sections like related issues, type, checklist, testing, and reviewer instructions. Add the missing template sections, especially related issue links, change type, checklist items, testing details, and reviewer guidance.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: updating the preview workflow to use facets-scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rename-facets-schemas-scripts-to-facets-scripts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant