Include already installed packages in PipResolver.gather#4
Open
cdcadman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of This Pull Request
Please check the relevant option by placing an "X" inside the brackets:
Overview of Changes
When using
PipResolver.gatherwith a requirements.txt file in an environment wherepip install -r requirements.txthas already been run,PipResolver.gatherreturns an empty set. This pull request would allow packages which were already installed in the environment to be included.Additional Notes
This is based on my assumption that
PipResolver.gathershould gather the requirements independently of what is already installed in the current environment.