CI coverage of auto generated stubs#4101
Draft
schnellerhase wants to merge 5 commits into
Draft
Conversation
schnellerhase
force-pushed
the
schnellerhase/mypy-ci
branch
from
86fd57a to
e99a6d2
Compare
schnellerhase
force-pushed
the
schnellerhase/mypy-ci
branch
6 times, most recently
from
a60754b to
15e3fe9
Compare
This was referenced Mar 19, 2026
Merged
schnellerhase
force-pushed
the
schnellerhase/mypy-ci
branch
from
8c8a410 to
d7b2dee
Compare
schnellerhase
force-pushed
the
schnellerhase/generics
branch
from
36886a4 to
5944836
Compare
Member
|
Would be good to get this substantial PR in before it gets stale. What needs sorting still? |
jhale
reviewed
Apr 18, 2026
Member
There was a problem hiding this comment.
I do have my concerns here - if we add another type, we need to change this definition in 100 files. Can't it be in a library and imported?
Contributor
Author
schnellerhase
force-pushed
the
schnellerhase/generics
branch
5 times, most recently
from
d55000f to
a0d66b7
Compare
schnellerhase
force-pushed
the
schnellerhase/mypy-ci
branch
from
d7b2dee to
b77c229
Compare
* add cpp stub files * fix nanobind OUTPUT path Note that these OUTPUT are not actually passed to the stub generator and purely used for dependency management within CMake.
schnellerhase
force-pushed
the
schnellerhase/mypy-ci
branch
from
b77c229 to
f4d0bc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readds #4096 - now with cpp standalone mypy check for CI coverage, which catches #4096 (comment).