Expose localizable notice metadata

[ocepkejepintu-droid]

Summary

• add optional i18n_key, i18n_args, and expires_at fields to NoticeInfo
• keep the existing Java-friendly two-argument constructor for current client callers
• cover deserialization of the localizable notice payload used by Add localizable metadata to ban notices server#1083

Verification

• JAVA_HOME=/Users/yoseph/Codexperiment/.deps/jdk21/Contents/Home ./gradlew test — 75 tests passed
• JAVA_HOME=/Users/yoseph/Codexperiment/.deps/jdk21/Contents/Home ./gradlew :lobby:test --tests com.faforever.commons.lobby.ServerMessageTest — 22 tests passed
• git diff --check

Related: FAForever/server#1083

[coderabbitai]

Warning

Rate limit exceeded

@ocepkejepintu-droid has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 23 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa5e893c-eba6-41b0-9bd5-a3d5684b177e

📥 Commits

Reviewing files that changed from the base of the PR and between 50328af and 4c7c19b.

📒 Files selected for processing (2)

• lobby/src/main/kotlin/com/faforever/commons/lobby/ConnectionApi.kt
• lobby/src/test/kotlin/com/faforever/commons/lobby/ServerMessageTest.kt

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}