Skip to content

Change 3 prop normal textures from size 518x518 to 512x512 #6982

Merged
BlackYps merged 3 commits intoFAForever:developfrom
TrafficConeOfSchooling:fixedtexturesize
Apr 11, 2026
Merged

Change 3 prop normal textures from size 518x518 to 512x512 #6982
BlackYps merged 3 commits intoFAForever:developfrom
TrafficConeOfSchooling:fixedtexturesize

Conversation

@TrafficConeOfSchooling
Copy link
Copy Markdown
Contributor

@TrafficConeOfSchooling TrafficConeOfSchooling commented Dec 16, 2025

Description of the proposed changes

I have resized 3 of the normal textures for the ancient earth props to 512 x 512:
eg_bush01_normalsTS.dds
eg_bush02_normalsTS.dds
eg_bush03_normalsTS.dds
These textures were originally at size 518 x 518 which is incompatible with BC3 texture compression.
image
Hence this error message when the map editor loads the ancient-earth props section.

Testing done on the proposed changes

I took the entire ancient-earth prop folder out of the game files and pasted it into a test map's props folder.
Loading the map folder's props still resulted in the error.
Replacing the 518 x 518 textures with 512 x 512 versions allowed every prop in the map folder to be loaded and used properly.

Checklist

Summary by CodeRabbit

  • Bug Fixes
    • Resized 3 prop normal textures (518×518 → 512×512) to enable BC3 compression compatibility, allowing all ancient-earth props to load in the FAF map editor.

This will allow the FAF map editor to load props from the ancient-earth section. BC3 texture compression requires a multiple of 4 (in texture size) on every prop related texture  for the map editor to load any props from that section.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 16, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f5835ed8-400d-45a5-b73c-7c9e29791823

📥 Commits

Reviewing files that changed from the base of the PR and between bd01955 and da95141.

📒 Files selected for processing (1)
  • changelog/snippets/fix.6982.md
✅ Files skipped from review due to trivial changes (1)
  • changelog/snippets/fix.6982.md

📝 Walkthrough

Walkthrough

A changelog snippet was added documenting that three prop normal textures were resized from 518×518 to 512×512 to enable BC3 texture compression and allow the FAF map editor to load all entries from the ancient-earth props section.

Changes

Cohort / File(s) Summary
Changelog entry
changelog/snippets/fix.6982.md
Adds a changelog snippet noting that 3 prop normal textures were resized from 518×518 to 512×512 for BC3 compression compatibility and FAF map editor loading.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • BlackYps

Poem

I’m a rabbit in the changelog light,
Three normals trimmed to fit just right.
518 to 512, hops of glee,
BC3 hums and the map loads free. 🐇✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly describes the main change: resizing 3 prop normal textures from 518x518 to 512x512, which matches the primary objective of the pull request.
Description check ✅ Passed The description covers the main sections including changes, testing, and partially addresses the checklist. However, the author has not requested 2-3 reviewers as specified in the template checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TrafficConeOfSchooling TrafficConeOfSchooling changed the title Change 3 prop normal textures from size 518x518 to 512x512 Change 3 prop normal textures from size 518x518 to 512x512 #6982 Dec 16, 2025
@TrafficConeOfSchooling TrafficConeOfSchooling changed the title Change 3 prop normal textures from size 518x518 to 512x512 #6982 Change 3 prop normal textures from size 518x518 to 512x512 Dec 16, 2025
@TrafficConeOfSchooling TrafficConeOfSchooling marked this pull request as ready for review December 16, 2025 23:24
@Garanas
Copy link
Copy Markdown
Member

Garanas commented Dec 17, 2025

This is a great find 👍 , the game is also unable to process non-power-of-two textures in some area's of the game, such as terrain stratum textures. It rescales the texture internally to the next power-of-two as it tries to load the texture.

@BlackYps BlackYps mentioned this pull request Apr 10, 2026
2 tasks
Copy link
Copy Markdown
Contributor

@BlackYps BlackYps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add - (#6982) at the beginning of the snippet and a dot at the end.

@TrafficConeOfSchooling
Copy link
Copy Markdown
Contributor Author

Please add - (#6982) at the beginning of the snippet and a dot at the end.

Done.

@BlackYps BlackYps merged commit 8f91cc8 into FAForever:develop Apr 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants