Change 3 prop normal textures from size 518x518 to 512x512 #6982
Change 3 prop normal textures from size 518x518 to 512x512 #6982BlackYps merged 3 commits intoFAForever:developfrom
Conversation
This will allow the FAF map editor to load props from the ancient-earth section. BC3 texture compression requires a multiple of 4 (in texture size) on every prop related texture for the map editor to load any props from that section.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA changelog snippet was added documenting that three prop normal textures were resized from 518×518 to 512×512 to enable BC3 texture compression and allow the FAF map editor to load all entries from the ancient-earth props section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is a great find 👍 , the game is also unable to process non-power-of-two textures in some area's of the game, such as terrain stratum textures. It rescales the texture internally to the next power-of-two as it tries to load the texture. |
BlackYps
left a comment
There was a problem hiding this comment.
Please add - (#6982) at the beginning of the snippet and a dot at the end.
Done. |
Description of the proposed changes
I have resized 3 of the normal textures for the ancient earth props to 512 x 512:

eg_bush01_normalsTS.dds
eg_bush02_normalsTS.dds
eg_bush03_normalsTS.dds
These textures were originally at size 518 x 518 which is incompatible with BC3 texture compression.
Hence this error message when the map editor loads the ancient-earth props section.
Testing done on the proposed changes
I took the entire ancient-earth prop folder out of the game files and pasted it into a test map's props folder.
Loading the map folder's props still resulted in the error.
Replacing the 518 x 518 textures with 512 x 512 versions allowed every prop in the map folder to be loaded and used properly.
Checklist
Summary by CodeRabbit