Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
MatiasArriola
left a comment
MatiasArriola
left a comment
There was a problem hiding this comment.
Thanks @anagperal !
Looks good to me, just a comment
| attributes: enrollment.attributes.map(att => { | ||
| const mappedAttributeId = | ||
| trackedEntityAttributesToTEI[att.attribute]?.mappedId ?? att.attribute; | ||
|
|
||
| const mappedValue = mapOptionValue(att.value, [ | ||
| trackedEntityAttributesToTEI[att.attribute]?.mapping ?? {}, | ||
| this.mapping, | ||
| ]); | ||
|
|
||
| return { | ||
| ...att, | ||
| attribute: mappedAttributeId, | ||
| value: mappedValue, | ||
| }; | ||
| }), |
There was a problem hiding this comment.
This could be extracted to a function to avoid code duplication (same is done for attributes and enrollment.attributes).
Even if it is a helper inside the method like const mapAttribute = (att: TrakedEntityAttribute) => { [...] I think it would be a good option
MatiasArriola
left a comment
MatiasArriola
left a comment
There was a problem hiding this comment.
Nice @anagperal! Thanks!
…tributes-teis # Conflicts: # src/data/transformations/__tests__/integration/teiTransformations-api.spec.ts
|
@adrianq The conflict is resolved. I had some issues running yarn start and yarn build. I needed to fix some dependencies using resolutions. |
|
@xurxodev Thanks! You already created a PR updating the dependencies, so we can revisit this issue, if needed, later on |
4 participants
📌 References
📝 Implementation
📹 Screenshots/Screen capture
Error before:
Now success
🔥 Is there anything the reviewer should know to test it?
📑 Others
Any change in the GUI library? If so, what branch/PR?
Any change in the D2 Api? If so, what branch/PR?