Update d2-api version and use D2ApiOptions instead of auth and baseUrl #13
Merged
adrianq merged 3 commits intodevelopmentfrom Feb 24, 2026
Merged
Update d2-api version and use D2ApiOptions instead of auth and baseUrl #13adrianq merged 3 commits intodevelopmentfrom
adrianq merged 3 commits intodevelopmentfrom
Conversation
…ose D2ApiOptions from library
tokland
approved these changes
Feb 20, 2026
| ( | ||
| acc: D2TrackerEventToPost["dataValues"], | ||
| message: TrackerProgramMessages | ||
| ): D2TrackerEventToPost["dataValues"] => [ |
Contributor
There was a problem hiding this comment.
I see the reduce was already there, but just as a note -> That code looks equivalent to:
const dataValuesFromMessages = messages.map(message => ({
dataElement: message.id,
value: message.value,
}));
return _.concat(dataValues, dataValuesFromMessages); // or [..., ...]It’s also more efficient, since reduce is O(n²). But more importantly, it’s more declarative. Typically, we don’t need reduce unless we’re doing some kind of stateful folding, and we use other abstractions that better capture the intent (map/fromItems/...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester