Feature: Add external database volume and external database connection#155
Open
nshandra wants to merge 4 commits intodevelopmentfrom
Open
Feature: Add external database volume and external database connection#155nshandra wants to merge 4 commits intodevelopmentfrom
nshandra wants to merge 4 commits intodevelopmentfrom
Conversation
Contributor
|
@nshandra Sorry, I had this pending. Can you merge with development? (re-add me when done) |
Contributor
Author
|
@tokland done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
Add parameters to d2-docker start to allow either:
Testing
External Persistent Volume Case
This case will store the DB volume at the specified absolute path.
External DB Case
This case needs a psql DB runnig in the machine hosting the dockers or in a accessible network.
This DB has to have the correct settings:
/etc/postgresql/{ver}/main/postgresql.confSet
listen_addressesto:'*'(easiest for testing)'localhost,172.17.0.1'(docker and DB in same system)'localhost,<reachable_ip>'/etc/postgresql/{ver}/main/pg_hba.confAdd an entry to allow the connection. Example:
Running d2-cloner:
#1ck80y8