Fix upgrade command that would stop during docker build#149
Open
cgbautista wants to merge 2 commits intodevelopmentfrom
Open
Fix upgrade command that would stop during docker build#149cgbautista wants to merge 2 commits intodevelopmentfrom
cgbautista wants to merge 2 commits intodevelopmentfrom
Conversation
… to choose between the different tomcat/java versions and tried to use `docker build` with 3 different Dockerfile in 3 subfolders Moved the sleep in wait_for_server to let docker start nginx before trying to connect to it (raising an exception). Even in the best case scenario in which nginx would start before reaching this code, tomcat would likely take a little extra to be ready, so the sleep will take place at least once (usually several times, since a migration would include some SQL to be run before tomcat would be in a ready state and until then a 502 error would be generated each time it is tested)
cgbautista
force-pushed
the
feature/glowroot
branch
from
f0babd9 to
e1ed7a8
Compare
idelcano
requested changes
Dec 22, 2025
idelcano
approved these changes
Dec 30, 2025
Contributor
idelcano
left a comment
idelcano
left a comment
There was a problem hiding this comment.
Its ok for me
thanks @cgbautista
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
upgradeargument, since it didn't perform the major_version check to choose between the different tomcat/java versions and tried to usedocker buildwith 3 different Dockerfile in 3 subfolders instead of the specific one for the version it is trying to upgrade to.Moved the sleep in wait_for_server to let docker start nginx before trying to connect to it (raising an exception). Even in the best case scenario in which nginx would start before reaching this code, tomcat would likely take a little extra to be ready, so the sleep will take place at least once (usually several times, since a migration would include some SQL to be run before tomcat would be in a ready state and until then a 502 error would be generated each time it is tested).
Moved common parts from
create.pytoutils.py