fix(#699): move batch state from transient to engine_data#710
Merged
Conversation
Homeboy Results —
|
Tests were using hardcoded flow_id=1/pipeline_id=1 which don't exist in the test DB. When the engine triggers FlowFiles::get_file_context() on child job creation, it throws because the flow doesn't exist. Fix: create real pipeline + flow in setUp and use those IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine_datacolumnbatch_state_missingfailures on 2026-03-07What changed
fanOut()— storesbatch_statekey in engine_data alongside existing batch metadata. No moreset_transient().processChunk()— readsbatch_statefrom engine_data, updates offset there between chunks,unset()s the key when all chunks are processed (or on cancellation). No moreget_transient()/delete_transient().Tests —
test_fanout_stores_transient→test_fanout_stores_batch_state_in_engine_data, zero-children test seeds engine_data instead of transient, newtest_batch_state_cleaned_up_after_all_chunks_processedtest.No backward compat for in-flight transient batches — any batch mid-flight during a deploy was already dead (that's the bug this fixes).
Closes #699