-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add expo plugin and example #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@wcastand any updates when this will be merged? |
|
@adnandothussain that's not on me unfortunately, i made the Pr never received feedback so before i ever look at conflict, i expect them to spend some time for review before i spend more time on it especially since conflict is just package maintenance most likely. |
|
Thank you for your response @wcastand |
|
You can do yeah we have it in prod right now |
|
By using your Gist https://gist.github.com/wcastand/4160c31062e085b043e4d78953642150 I have created expo plugin. Will it work in Prod? |
|
well test, i don't know your setup so i can't guarantee it, it works for us at least. 😅 |
Details
Adding an expo plugin to allow to use this library with expo CNG.
Adding documentation on how to configure and do.
I make the draft quickly mostly because i'm rusty on open source contribution. never really did an expo plugin as part of a public lib (always internal plugins and modules). We use biome and bun so didn't use prettier/eslint and npm in 4 years pretty much 😅
so i will need some guidance or help to make this a clean PR, sorry in advance.
Related Issues
#31
Manual Tests
i added an expo example app with the plugin in the config, not sure how to test since it needs the private lib for google pay.
TODO