Skip to content

Conversation

@wcastand
Copy link

@wcastand wcastand commented Oct 3, 2025

Details

Adding an expo plugin to allow to use this library with expo CNG.
Adding documentation on how to configure and do.

I make the draft quickly mostly because i'm rusty on open source contribution. never really did an expo plugin as part of a public lib (always internal plugins and modules). We use biome and bun so didn't use prettier/eslint and npm in 4 years pretty much 😅

so i will need some guidance or help to make this a clean PR, sorry in advance.

Related Issues

#31

Manual Tests

i added an expo example app with the plugin in the config, not sure how to test since it needs the private lib for google pay.

TODO

  • add expo plugin code
  • add documentation
  • add expo app example
  • fix eslint config issues with new plugin code

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@wcastand
Copy link
Author

wcastand commented Oct 3, 2025

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Oct 3, 2025
@wcastand wcastand marked this pull request as ready for review October 6, 2025 10:03
@adnandothussain
Copy link

@wcastand any updates when this will be merged?

@wcastand
Copy link
Author

@adnandothussain that's not on me unfortunately, i made the Pr never received feedback so before i ever look at conflict, i expect them to spend some time for review before i spend more time on it especially since conflict is just package maintenance most likely.

@adnandothussain
Copy link

Thank you for your response @wcastand
Any way i can integrate react-native-wallet in my existing expo app? If this PR will take some time?

@wcastand
Copy link
Author

You can do yeah we have it in prod right now
You need to to make custom local plugin and you should be able to

@adnandothussain
Copy link

By using your Gist https://gist.github.com/wcastand/4160c31062e085b043e4d78953642150

I have created expo plugin. Will it work in Prod?

@wcastand
Copy link
Author

well test, i don't know your setup so i can't guarantee it, it works for us at least. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants