Bump react-native-worklets to 0.10.x#763
Merged
Merged
Conversation
Collaborator
Author
376a321 to
e4bb29a
Compare
j-piasecki
approved these changes
Jul 3, 2026
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project to react-native-worklets@0.10.1 and adds a compatibility workaround for the new 0.10.x serialization behavior that throws on non-plain objects captured by worklet closures (notably expensify-common’s Log / Logger).
Changes:
- Bump
react-native-workletsfrom0.9.1to0.10.1(library + example app + iOS pods/lockfiles). - Register a custom serializer to replace captured
Loggerinstances with a no-op stand-in on the worklet runtime. - Update README compatibility matrix to include
react-native-worklets0.10.x.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MarkdownTextInput.tsx | Registers a custom worklets serializer to avoid crashes when a Logger instance is captured by the parser worklet closure. |
| README.md | Updates the worklets compatibility table to include 0.10.x. |
| package.json | Bumps react-native-worklets dependency to 0.10.1. |
| package-lock.json | Updates lockfile for react-native-worklets@0.10.1 and its dependency graph. |
| example/package.json | Bumps example app’s react-native-worklets dependency to 0.10.1. |
| example/ios/Podfile.lock | Updates CocoaPods lockfile to RNWorklets 0.10.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+36
| determine: (value): value is NoopLogger => { | ||
| 'worklet'; | ||
|
|
||
| return value !== null && typeof value === 'object' && (value as {constructor?: {name?: string}}).constructor?.name === 'Logger'; | ||
| }, |
bdceef1 to
22835b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Details
Bumps
react-native-workletsto0.10.1and adds compatibility with the 0.10.x line.Worklets 0.10 no longer silently substitutes an inaccessible placeholder for non-plain objects it can't serialize — it throws
Cannot copy value of type `Logger`instead. The built-inparseExpensiMarkparser's worklet closure transitively captures theLogsingleton fromexpensify-common(aLoggerclass instance), so registering the parser crashes the moment a<MarkdownTextInput>mounts.The logger is never invoked on the worklet runtime, so we register a custom serializer (
registerCustomSerializable) that replaces anyLoggerwith a no-op stand-in on the worklet side.Related Issues
N/A
Manual Tests
Cannot copy value of type `Logger`red screen on mount; with the fix the editor renders and live Markdown formatting works (typed*live*→ bold).Linked PRs
N/A
🤖 Generated with Claude Code