Move responsibility for configuring PDF worker to the consumer#52
Open
andriivitiv wants to merge 1 commit intoExpensify:mainfrom
Conversation
Open
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Details
We have switched between the modern and legacy PDF worker multiple times in the past. Each time we do this, we must update both E/App and this repo. PR #45 and Expensify/App#56473 are good examples of how we had to implement the same code twice, only to remove it later (again in both repos).
Furthermore, setting
pdfjs.GlobalWorkerOptions.workerSrcin E/App has no effect because it would get overridden by this line:react-fast-pdf/src/PDFPreviewer.tsx
Line 35 in 0388690
Even with the correct import order, both worker builds would be included in the bundle, increasing its size.
This PR removes the default worker configuration and instead expects applications using this library to configure it, which is the same approach used by
react-pdf. This makes it more reliable and easier to maintain (we will only need to update the worker once in E/App).Related Issues
Expensify/App#76303
Manual Tests
npm run build && npm pack.npm install ../react-fast-pdf-1.0.31.tgz.Linked PRs