Skip to content

Fix incorrect currency symbol in distance rate update changelog message - #98389

Open
mukhrr wants to merge 1 commit into
Expensify:mainfrom
mukhrr:fix/93144
Open

Fix incorrect currency symbol in distance rate update changelog message#98389
mukhrr wants to merge 1 commit into
Expensify:mainfrom
mukhrr:fix/93144

Conversation

@mukhrr

@mukhrr mukhrr commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The rate-creation changelog message formats the raw amount client-side with Intl (convertAmountToDisplayString), but the rate-update message rendered backend-preformatted oldValue/newValue strings verbatim, so currencies like ARS showed the currency-list symbol (AR$1,40) instead of the Intl format (ARS 1.40).

The backend now sends raw oldRate/newRate (in cents) and currency in the POLICYCHANGELOG_UPDATE_CUSTOM_UNIT_RATE original message. This PR makes getWorkspaceCustomUnitRateUpdatedMessage prefer those raw fields and format them with convertAmountToDisplayString, the same helper the creation message uses, so both messages agree for every currency. The legacy oldValue/newValue string branch is kept as a fallback for old cached actions.

Fixed Issues

$ #93144
PROPOSAL: #93144 (comment)

Tests

Precondition: a workspace whose currency is not USD (e.g. ARS) with Distance rates enabled.

  1. Go to Workspaces > [workspace] > Distance rates.
  2. Click "Add rate" and create a rate, e.g. 1.30.
  3. Open the newly created rate and update the amount, e.g. to 1.40.
  4. Go to the workspace #Admins room.
  5. Verify the "changed the rate of the distance rate..." message shows the amount in the same format as the rate-creation message (e.g. ARS 1.40 (previously ARS 1.30)), not the currency symbol (AR$1,40).
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
IOS_app.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
IOS_app.mp4
iOS: mWeb Safari
IOS_web.mp4
MacOS: Chrome / Safari
93144-web.mp4

@mukhrr
mukhrr requested review from a team as code owners August 12, 2026 02:58
@melvin-bot
melvin-bot Bot requested review from garrettmknight and truph01 August 12, 2026 02:58
@melvin-bot

melvin-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team August 12, 2026 02:58
@truph01

truph01 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@mkhutornyi It looks like you are reviewer of this one, right?

@mkhutornyi

Copy link
Copy Markdown
Contributor

@mkhutornyi It looks like you are reviewer of this one, right?

right

@truph01

truph01 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@garrettmknight Could you assign @mkhutornyi and unassign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants