Reword stale removed-from-QBO vendor comment to reference the accounting integration generically - #98388
Reword stale removed-from-QBO vendor comment to reference the accounting integration generically#98388MelvinBot wants to merge 1 commit into
Conversation
…egration generically Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
|
The only failing checks are non-code checks that I can't resolve by pushing to the branch — every actual code/test check is green. Failing:
Passing: Bun tests, ESLint, Oxfmt, typecheck, Storybook, React Compiler, spellcheck, and all 8 Jest There's nothing for me to fix in the code — this PR just needs the author checklist completed and a reviewer approval. |
|
Still the same two non-code checks failing — nothing I can push a fix for:
Every code/test check (Bun tests, ESLint, Oxfmt, typecheck, Storybook, React Compiler, spellcheck, all 8 Jest |
Explanation of Change
This is a comment-only change — no runtime behavior is affected.
The
inactiveVendorviolation was recently generalized in Auth (Auth#23497) so it now fires for Sage Intacct and Xero in addition to QuickBooks Online. A stale inline comment inIOURequestStepVendor.tsxstill described the cleared vendor as "removed-from-QBO", which is now inaccurate. This reworks it to reference the accounting integration generically ("removed from the accounting integration").This is follow-up 2 from Expensify/Expensify#668349.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/668349
PROPOSAL:
Tests
Comment-only change; no functional behavior changes. Nothing to test at runtime.
Offline tests
N/A — comment-only change.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari