[No QA] Drop obsolete expo-modules-jsi Xcode 26.2 type-inference patch - #98379
Conversation
The patch worked around a Swift type-inference bug specific to Xcode 26.2. The iOS build pipeline now uses Xcode 26.6 (#97774), so this workaround should no longer be needed. Removing it to verify a clean build. Co-authored-by: Rory Abraham <roryabraham@users.noreply.github.com>
|
I looked into the failing checks — there's nothing to fix with a code push. Both failures are process gates, not code/build failures:
Every actual CI/build check is either passing or still pending ( To clear the two red checks: tick the PR Author Checklist boxes and get a reviewer approval. No code change is needed from me. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
Re-checked — still nothing for me to fix with a code push. The only two red checks are process gates, not code/build failures:
Every actual CI/build check is passing or still running ( To clear the two red checks: tick the PR Author Checklist boxes and get a reviewer approval. And since this is a build-tooling change, the meaningful validation is the adhoc |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Drops the
expo-modules-jsipatch that was added specifically to workaround an XCode 26.2 limitation, since we've upgraded to XCode 26.6 in CIFixed Issues
$
Tests
None - build-time only. Verified with a test build.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop