Revert #97005 (reconciled) - #98349
Draft
MelvinBot wants to merge 1 commit into
Draft
Conversation
Straight revert of #97005 was not possible because ~110 later commits touched the same files. Restored the pre-#97005 versions of MoneyRequestReportTransactionsNavigation.tsx, Search/index.tsx and el.ts, re-applying the subsequently-added required personalDetails threading so the tree still type-checks.
Contributor
Author
|
I created this PR from an upstream branch since you don't have push access to update it directly. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. You can still edit the description (Tests/QA) directly here via the GitHub UI without push access. |
40 tasks
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Reverts #97005 ("Standardize Expense Report and Expense header with predictable button placement and carousel counter"), which introduced a set of regressions tracked in the issues below.
A straight
git revertof #97005 was not possible: ~110 commits have landed on the same files since it merged on 2026-08-07, so backing out its diff conflicted inMoneyRequestReportTransactionsNavigation.tsx,Search/index.tsxandel.ts. This is a reconciled revert:personalDetailsparam intogetReportIDToOpenForExpense(...)andcreateTransactionThreadReport({...}), so the restored code still type-checks against the current shared-util signatures.Verification performed by MelvinBot:
npm run typecheck-tsgo— passes.npm run lint-changed— passes.npm run fmt— clean.tests/ui/components/MoneyReportHeaderMoreContentTest.tsx— 4/4 pass.Fixed Issues
$ #98200
$ #98196
$ #98193
$ #98192
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changes worked. Suggested: open an expense report with 3+ expenses, confirm the report/expense header renders and the prev/next carousel navigates between sibling expenses.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.