Skip to content

Revert #97005 (reconciled) - #98349

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-revertPR97005
Draft

Revert #97005 (reconciled)#98349
MelvinBot wants to merge 1 commit into
mainfrom
claude-revertPR97005

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Reverts #97005 ("Standardize Expense Report and Expense header with predictable button placement and carousel counter"), which introduced a set of regressions tracked in the issues below.

A straight git revert of #97005 was not possible: ~110 commits have landed on the same files since it merged on 2026-08-07, so backing out its diff conflicted in MoneyRequestReportTransactionsNavigation.tsx, Search/index.tsx and el.ts. This is a reconciled revert:

Verification performed by MelvinBot:

  • npm run typecheck-tsgo — passes.
  • npm run lint-changed — passes.
  • npm run fmt — clean.
  • Restored unit test tests/ui/components/MoneyReportHeaderMoreContentTest.tsx — 4/4 pass.
  • Automated web UI verification was attempted but blocked by an unrelated signed-in session rendering a blank page in CI; it did not exercise the reverted header/carousel. The human co-author should manually verify the flows below.

Fixed Issues

$ #98200
$ #98196
$ #98193
$ #98192

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changes worked. Suggested: open an expense report with 3+ expenses, confirm the report/expense header renders and the prev/next carousel navigates between sibling expenses.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Straight revert of #97005 was not possible because ~110 later commits touched the same files. Restored the pre-#97005 versions of MoneyRequestReportTransactionsNavigation.tsx, Search/index.tsx and el.ts, re-applying the subsequently-added required personalDetails threading so the tree still type-checks.
@MelvinBot
MelvinBot requested a review from a team August 11, 2026 19:01
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since you don't have push access to update it directly.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-revertPR97005
git checkout -b claude-revertPR97005 upstream/claude-revertPR97005
git push -u origin claude-revertPR97005

Then you can close this PR and open a new one from your fork. You can still edit the description (Tests/QA) directly here via the GitHub UI without push access.

@MelvinBot MelvinBot mentioned this pull request Aug 11, 2026
40 tasks
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/components/MoneyReportHeaderMoreContent.tsx 100.00% <100.00%> (+100.00%) ⬆️
...stReportView/MoneyRequestReportTransactionList.tsx 0.29% <ø> (+<0.01%) ⬆️
...archList/ListItem/TransactionGroupListExpanded.tsx 67.69% <ø> (ø)
src/components/Search/index.tsx 49.65% <ø> (+0.90%) ⬆️
src/libs/ExportOnyxState/common.ts 80.35% <ø> (ø)
src/pages/home/RecentlyAddedSection/index.tsx 100.00% <ø> (ø)
src/pages/inbox/ReportNavigateAwayHandler.tsx 70.12% <100.00%> (-0.39%) ⬇️
src/components/MoneyRequestHeader.tsx 0.00% <0.00%> (ø)
src/components/PopoverMenu/index.tsx 91.48% <0.00%> (+3.73%) ⬆️
... and 4 more
... and 54 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants