Fix submissions thread headers - #98334
Draft
stitesExpensify wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds the missing
UPDATE_AUTO_HARVESTINGreport-action handler to report-name computation. Thread headers now reuse the existing localized message helper used by the in-chat message and LHN preview, so disabling Submissions displaysdisabled submissionsconsistently.The root cause was that
computeReportNameBasedOnReportActiondid not handle this action type and admin-room thread names fell through to the raw backend text,turned Scheduled Submit off.Fixed Issues
$ #98202
PROPOSAL: #98202 (comment)
Tests
npm test -- tests/unit/ReportNameUtilsTest.ts --runInBand.disabled submissionssystem message thread.disabled submissions.enabled submissions.The local automated test run was attempted but was blocked by the existing shared dependency setup: the checkout's available dependencies are from an older App revision and are missing the Babel module path required by this
origin/mainrevision.Offline tests
N/A. This change only computes a localized name from report-action data already available in the client and does not add network behavior.
QA Steps
disabled submissionswording.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionorigin/mainScreenshots/Videos
Android: Native
N/A. Logic-only change.
Android: mWeb Chrome
QA steps above.
iOS: Native
N/A. Logic-only change.
iOS: mWeb Safari
N/A. Logic-only change.
MacOS: Chrome / Safari
QA steps above.