Add Payer search filter UI, table column, sorting, and export - #98326
Add Payer search filter UI, table column, sorting, and export#98326c3024 wants to merge 4 commits into
Conversation
The payer filter is now shown in the advanced filters and filter bar as a multi-select user filter, and a Payer column is available on expense report search views. The column is derived from the actor of the latest payment report action returned in the search snapshot, matching how First approver is derived, and is sortable and exportable.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
payer:filter in the advanced filters and filter bar as a multi-select user filter for expense, expense report, invoice, and trip searches. The form value changes from a single string tostring[]andpayer:menow resolves likefrom:/to:.Requires Auth PR 23652 for the filter to match who actually paid, the snapshot to include the payment action, server-side sorting, and export.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/670393
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari