Skip to content

Add Payer search filter UI, table column, sorting, and export - #98326

Draft
c3024 wants to merge 4 commits into
Expensify:mainfrom
c3024:chaitanya/670393-payer-search-filter
Draft

Add Payer search filter UI, table column, sorting, and export#98326
c3024 wants to merge 4 commits into
Expensify:mainfrom
c3024:chaitanya/670393-payer-search-filter

Conversation

@c3024

@c3024 c3024 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Surfaces the existing payer: filter in the advanced filters and filter bar as a multi-select user filter for expense, expense report, invoice, and trip searches. The form value changes from a single string to string[] and payer:me now resolves like from:/to:.
  • Adds a Payer column to expense report search views, derived from the actor of the latest payment report action in the snapshot (same pattern as First approver), with sorting and CSV export support.

Requires Auth PR 23652 for the filter to match who actually paid, the snapshot to include the payment action, server-side sorting, and export.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/670393
PROPOSAL:

Tests

  1. Sign in as a workspace admin who has paid reports (or pay a submitted report as the reimburser).
  2. Go to Reports > Expense reports and open the columns picker. Enable the Payer column.
  3. Verify the Payer column shows the person who paid each paid report and is blank for unpaid reports.
  4. Click the Payer column header and verify the rows sort by payer name.
  5. Open Filters, choose Payer, select one or more users, and apply.
  6. Verify the results only include reports paid by (or awaiting payment from) the selected users, and the filter bar shows a Payer chip.
  7. Select the paid reports and use Download to export CSV. Verify the exported file has a Payer column with the payer's name.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Open Filters, choose Payer, select a user, and apply.
  3. Verify the filter chip renders with the selected user's name and the query updates once back online.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

The payer filter is now shown in the advanced filters and filter bar as a
multi-select user filter, and a Payer column is available on expense report
search views. The column is derived from the actor of the latest payment
report action returned in the search snapshot, matching how First approver
is derived, and is sortable and exportable.
@melvin-bot

melvin-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
...ents/Search/FilterComponents/ListFilterContent.tsx 0.00% <ø> (ø)
src/components/Search/SearchList/ListItem/types.ts 100.00% <ø> (ø)
...onents/Search/SearchPageHeader/SearchFilterBar.tsx 2.85% <ø> (ø)
src/components/Search/SearchTableHeader.tsx 49.43% <ø> (ø)
src/hooks/useAdvancedSearchFilters.ts 97.50% <ø> (ø)
src/libs/SearchQueryUtils.ts 87.40% <100.00%> (+0.09%) ⬆️
src/styles/utils/index.ts 57.43% <100.00%> (-0.11%) ⬇️
src/types/form/SearchAdvancedFiltersForm.ts 100.00% <ø> (ø)
...ReportListItemRow/ExpenseReportListItemRowWide.tsx 0.00% <0.00%> (ø)
... and 1 more
... and 172 files with indirect coverage changes

@quinthar quinthar added the #migrate Relates to work in the #migrate room label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#migrate Relates to work in the #migrate room

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants