[No QA] Add DualEntry action tests and docs - #98316
Open
ShridharGoel wants to merge 2 commits into
Open
Conversation
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
August 11, 2026 15:00
trjExpensify
removed their request for review
August 11, 2026 22:38
Contributor
|
PR doesn’t need product input as a code-cleanup PR. Unassigning and unsubscribing myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This follow-up to #97506 adds documentation for the DualEntry import API parameters.
It also adds unit tests for all exported DualEntry connection actions. The tests verify API parameters and optimistic, success, and failure Onyx data.
Fixed Issues
$ #97237
PROPOSAL:
Tests
npm test -- --runInBand --watchman=false tests/unit/DualEntryActionTest.ts.Offline tests
Not required. This PR only adds documentation and unit tests.
QA Steps
No QA is required. This PR only adds documentation and unit tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components using it are working as expected)Designlabel and/or tagged@Expensify/designmainwas merged after review, I tested againScreenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari