Skip to content

[No QA] Add DualEntry action tests and docs - #98316

Open
ShridharGoel wants to merge 2 commits into
Expensify:mainfrom
ShridharGoel:fix-dualentry-action-tests-docs
Open

[No QA] Add DualEntry action tests and docs#98316
ShridharGoel wants to merge 2 commits into
Expensify:mainfrom
ShridharGoel:fix-dualentry-action-tests-docs

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This follow-up to #97506 adds documentation for the DualEntry import API parameters.

It also adds unit tests for all exported DualEntry connection actions. The tests verify API parameters and optimistic, success, and failure Onyx data.

Fixed Issues

$ #97237
PROPOSAL:

Tests

  1. Run npm test -- --runInBand --watchman=false tests/unit/DualEntryActionTest.ts.
  2. Verify that all six tests pass.
  • Verify that no errors appear in the JS console

Offline tests

Not required. This PR only adds documentation and unit tests.

QA Steps

No QA is required. This PR only adds documentation and unit tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using it are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component
  • If the PR modifies a component related to any existing Storybook stories, I tested and verified all stories still work
  • If the PR modifies a component or page accessed by a direct deeplink, I verified it while logged in and logged out
  • If the PR modifies the UI or form input styles:
    • I verified that all inputs inside a form are aligned
    • I added the Design label and/or tagged @Expensify/design
  • I added unit tests for this change
  • If main was merged after review, I tested again

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@ShridharGoel
ShridharGoel marked this pull request as ready for review August 11, 2026 15:00
@ShridharGoel
ShridharGoel requested review from a team as code owners August 11, 2026 15:00
@melvin-bot
melvin-bot Bot requested review from truph01 and removed request for a team August 11, 2026 15:00
@melvin-bot

melvin-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team August 11, 2026 15:00
@trjExpensify
trjExpensify removed their request for review August 11, 2026 22:38
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a code-cleanup PR. Unassigning and unsubscribing myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants