[HOLD] [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD#93457
[HOLD] [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD#93457MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (267KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I analyzed the failing checks — there's no code fix to push. Every functional check passes:
The only thing that failed was Those are human-only sections — I don't fill out the Tests/QA checklist on an author's behalf. To clear this check, the human author needs to tick the checklist boxes and complete the Tests/QA steps. Verification detailsThis PR only changes user-facing string content in
|
|
@mananjadhav can you please approve the PR but not merge it? It's for QAing these steps. |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #93456 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
@lakchote Done. |
Explanation of Change
Updates the English (
src/languages/en.ts) copy so that every user-facing reference to "QuickBooks Desktop" now reads "QBD", per the request in the linked issue. Only string content was changed — no TS string delimiters or other locale files were touched. All 25 occurrences inen.tswere updated.Fixed Issues
$ #93456
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari