Skip to content

[HOLD] [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD#93457

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-qbdEnglishTranslation
Open

[HOLD] [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD#93457
MelvinBot wants to merge 1 commit into
mainfrom
claude-qbdEnglishTranslation

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the English (src/languages/en.ts) copy so that every user-facing reference to "QuickBooks Desktop" now reads "QBD", per the request in the linked issue. Only string content was changed — no TS string delimiters or other locale files were touched. All 25 occurrences in en.ts were updated.

Fixed Issues

$ #93456
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validates your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

  • Verify that no errors appear in the JS console

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 12, 2026 17:03
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (267KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw 7679347383eb4736b998835c8f73afb3 | git apply 😉

View workflow run

@lakchote lakchote marked this pull request as ready for review June 12, 2026 17:09
@lakchote lakchote requested a review from a team as a code owner June 12, 2026 17:09
@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and mananjadhav and removed request for a team June 12, 2026 17:10
@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 12, 2026 17:10
@lakchote lakchote changed the title Update English translation: QuickBooks Desktop -> QBD [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD Jun 12, 2026
@lakchote lakchote changed the title [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD [HOLD] [QA test - Do not merge] Update English translation: QuickBooks Desktop -> QBD Jun 12, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I analyzed the failing checks — there's no code fix to push. Every functional check passes:

  • typecheck, ESLint, Prettier, spellcheck
  • ✅ All 8 test jobs, Storybook tests
  • generateTranslations, all build variants, React Compiler Compliance, Check for unused styles

The only thing that failed was PR Author Checklist / checklist, and it failed for a non-code reason: You completed 0 out of 49 checklist items. The PR Author Checklist boxes are unchecked and the ### Tests / ### QA Steps sections still contain the // TODO placeholders.

Those are human-only sections — I don't fill out the Tests/QA checklist on an author's behalf. To clear this check, the human author needs to tick the checklist boxes and complete the Tests/QA steps.

Verification details

This PR only changes user-facing string content in src/languages/en.ts ("QuickBooks Desktop" → "QBD"). I checked whether any test asserts on that copy:

baseline-perf-tests / branch-perf-tests were still running at analysis time — they're advisory Reassure render-time benchmarks and can't be affected by a string-only copy change.

@lakchote

Copy link
Copy Markdown
Contributor

@mananjadhav can you please approve the PR but not merge it?

It's for QAing these steps.

@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #93456 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@mananjadhav

Copy link
Copy Markdown
Collaborator

@lakchote Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants