Skip to content

[Payment due @parasharrajat] Inbox filters#92146

Merged
Gonals merged 36 commits into
mainfrom
youssef_inbox_filters
Jun 12, 2026
Merged

[Payment due @parasharrajat] Inbox filters#92146
Gonals merged 36 commits into
mainfrom
youssef_inbox_filters

Conversation

@youssef-lr

@youssef-lr youssef-lr commented May 30, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds filter tabs to the top of the Inbox LHN — All, Unread, To-dos — that filter the report list:

  • All — every report, unchanged behavior (still honors Most Recent / Focus mode ordering).
  • Unread — only reports with unread, non-muted messages.
  • To-dos — only reports requiring action (outstanding GBR/RBR).

Each tab shows a count badge of how many reports it contains (hidden when 0). The selected tab is persisted via the nvp_inboxTab NVP. Priority (Focus) mode is preserved and continues to apply within the All tab.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/640582

Tests

  1. Open the Inbox. Verify three tabs at the top — All, Unread, To-dos — with All selected by default.
  2. Verify "Unread" and "To-dos" tabs show a count badge matching the number of reports in it, and the badge is hidden when the count is 0.
  3. Tap Unread and verify only chats with unread messages are listed.
  4. Tap To-dos and verify only chats with a green/red indicator (GBR/RBR, requiring action) are listed.
  5. Tap All and verify the full list returns.
  6. Receive a new message in a chat so it becomes unread; verify the Unread count increments and the chat appears under Unread. Open/read it and verify it leaves Unread and the count decrements.
  7. Trigger a chat that needs action (e.g. a report awaiting your approval); verify it appears under To-dos and is counted.
  8. Switch tabs, navigate away and back (or reload); verify the selected tab persists.
  9. Go to Settings > Preferences > Priority Mode, set #focus; verify the All tab still applies focus-mode behavior, then set it back to Most recent.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Switch between All / Unread / To-dos and verify filtering and counts still work (filtering is client-side from existing Onyx data).

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I verified that similar component doesn't exist in the codebase
  • I verified that all props are defined accurately and each prop has a /** comment above it */
  • I verified that each file is named correctly
  • I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • I verified that the only data being stored in component state is data necessary for rendering and nothing else
  • In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • I verified that all JSX used for rendering exists in the render method
  • I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

shawnborton and others added 6 commits April 17, 2026 12:29
Replace the hidden Focus/Priority mode toggle in Account > Preferences
with visible tab filters at the top of the Inbox: All, Unread, Expenses,
and Direct messages. This gives users immediate, discoverable control
over which chats they see.

- Add CONST.INBOX_TAB and ONYXKEYS.NVP_INBOX_TAB for tab state
- Add filterReportsForInboxTab() post-filter in SidebarUtils
- Add InboxTabSelector component using TabSelectorBase with small size
- Add 'small' size variant to TabSelector components (28px height, 11px font)
- Remove isInFocusMode from the entire report pipeline
- Remove PriorityModeHandler, PriorityModeController, FocusModeNotification
- Remove PriorityModePage and its route/navigation config
- Remove updateChatPriorityMode API command
- Update all test files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace the Unread tab with a "To do" tab that shows items needing
action (GBR/RBR indicators). Rename Direct Messages to DMs.

Add a separate Unreads toggle in the Inbox header using a small 20px
Switch component. The toggle filters to show only unread items and
works across all tabs. State persists via NVP_INBOX_UNREAD_FILTER.

- Add 'small' size variant to Switch component (36x20 track, 14x14 thumb)
- Add switchTrackSmall/switchThumbSmall styles
- Add InboxUnreadToggle component with "Unreads" label + small switch
- Update filterReportsForInboxTab to apply unread filter orthogonally

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Simplify inbox filtering to four straightforward tabs:
All, Unread, Expenses, and DMs. Remove the separate Unreads toggle
and To-do tab in favor of a clean Unread tab that shows only
unread and non-muted chats. Pinned/GBR/RBR items show only if
they qualify for the active tab filter.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolve conflicts with upstream changes that added isOffline parameter
and refactored shouldDisplayReportInLHN to use a params object.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@codecov

codecov Bot commented May 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/components/ScrollOffsetContextProvider.tsx 72.41% <100.00%> (+2.04%) ⬆️
src/components/TabSelector/TabSelectorBase.tsx 94.59% <100.00%> (ø)
src/components/TabSelector/TabSelectorItem.tsx 100.00% <100.00%> (ø)
src/pages/inbox/sidebar/BaseSidebarScreen.tsx 100.00% <100.00%> (ø)
src/pages/inbox/sidebar/SidebarLinks.tsx 93.54% <100.00%> (+0.44%) ⬆️
src/pages/inbox/sidebar/SidebarLinksData.tsx 80.64% <100.00%> (ø)
src/styles/index.ts 59.37% <100.00%> (+0.30%) ⬆️
src/libs/actions/User.ts 36.63% <0.00%> (+0.37%) ⬆️
... and 4 more
... and 111 files with indirect coverage changes

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@OSBotify

This comment has been minimized.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@youssef-lr

Copy link
Copy Markdown
Contributor Author

Unable to get the adhoc build to update, it's using cached code. I'll make a new dummy PR just so I can make a build

@youssef-lr youssef-lr marked this pull request as ready for review June 2, 2026 14:00
@youssef-lr youssef-lr requested a review from a team as a code owner June 2, 2026 14:00
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Tested. That looks good to me 👍

@youssef-lr

Copy link
Copy Markdown
Contributor Author

any updates @parasharrajat? it'd be great if you can prioritize this as we want it deployed to prod by Monday.

@parasharrajat

parasharrajat commented Jun 11, 2026

Copy link
Copy Markdown
Member

Yes, it looks good to me. I will add the checklist again in sometime. I was waiting on Design team approval.

@parasharrajat

parasharrajat commented Jun 11, 2026

Copy link
Copy Markdown
Member

Screenshots

🔲 iOS / native

06.06.2026_00.46.34_REC.mp4

🔲 iOS / Safari

06.06.2026_00.50.20_REC.mp4

🔲 MacOS / Chrome

06.06.2026_00.31.15_REC.mp4
12.06.2026_01.20.39_REC.mp4

🔲 Android / native

12.06.2026_01.34.33_REC.mp4

@youssef-lr

Copy link
Copy Markdown
Contributor Author

Thank you!

@parasharrajat

Copy link
Copy Markdown
Member

I noticed one thing: when we complete the task from a report in ToDo tab, that report moves to the end of the list of chats in LHN. @youssef-lr

12.06.2026_01.22.42_REC.mp4

@parasharrajat

parasharrajat commented Jun 11, 2026

Copy link
Copy Markdown
Member

I am going to paste the checklist in case we think above comment is not an issue.

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@parasharrajat

Copy link
Copy Markdown
Member

Do check this comment #92146 (comment)

@melvin-bot melvin-bot Bot requested a review from Gonals June 11, 2026 20:07
@melvin-bot

melvin-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title Inbox filters [Payment due @parasharrajat] Inbox filters Jun 11, 2026
@melvin-bot

melvin-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🎯 @parasharrajat, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/640582.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@Gonals Gonals merged commit 462368d into main Jun 12, 2026
39 checks passed
@Gonals Gonals deleted the youssef_inbox_filters branch June 12, 2026 09:35
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.7-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — changes required ✅

This PR adds user-facing Inbox filter tabs (All, Unread, To-dos) with count badges and a persisted tab selection. That behavior isn't documented on the help site, so an update is warranted.

What I updated: the Navigating New Expensify article — which already documents the Inbox tab — now has a How to filter your Inbox using tabs section describing the three tabs, the count badges, and the persisted selection. Labels and capitalization were taken verbatim from the merged source (src/languages/en.ts: inboxTabs.all = All, inboxTabs.unread = Unread, inboxTabs.todo = To-dos), and the change follows HELP_AUTHORING_GUIDELINES.md (task-based ## How to… heading, single # title, screenshot placeholder as an HTML comment).

Draft help site PR: #93479 (labeled HelpDot, assigned to youssef-lr)

@youssef-lr, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@nlemma

nlemma commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Blocker #93497 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93498 was identified to be related to this PR.

@youssef-lr

youssef-lr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

One is expected behavior, the other is a minor cosmetic issue in Android landscape. Demoted.

@nlemma

nlemma commented Jun 13, 2026

Copy link
Copy Markdown

Deploy Blocker #93521 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.