Skip to content

Revert "Fix distance rate auto-selection when submitting from Self DM to workspace" #86348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aldo-expensify wants to merge 1 commit into from
Closed

Revert "Fix distance rate auto-selection when submitting from Self DM to workspace" #86348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MoneyRequestConfirmationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@
!isPolicyExpenseChat ||
!transactionID ||
!lastSelectedRate ||
(isMovingTransactionFromTrackExpense && customUnitRateID === CONST.CUSTOM_UNITS.FAKE_P2P_ID) ||
isMovingTransactionFromTrackExpense ||
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow auto-select when moving expense rate ID is '-1'

This unconditional isMovingTransactionFromTrackExpense guard blocks the setCustomUnitRateID(..., lastSelectedRate, ...) path for all submit/share/categorize flows, including the distance-rate upgrade/new-rate flow where we intentionally set customUnitRateID to '-1' before returning to confirmation (src/pages/iou/request/step/IOURequestStepUpgrade.tsx:111). In that scenario, the effect now exits early and never applies the last selected workspace rate, which regresses rate auto-selection and can leave users with an invalid/default rate unless they manually reselect it.

Useful? React with 👍 / 👎.

!selectedParticipants.some((participant) => participant.policyID === policy?.id)
) {
return;
Expand Down Expand Up @@ -1142,7 +1142,7 @@
onSendMoney?.(paymentMethod);
}
},
[

Check warning on line 1145 in src/components/MoneyRequestConfirmationList.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

React Hook useCallback has a missing dependency: 'isNewManualExpenseFlowEnabled'. Either include it or remove the dependency array

Check warning on line 1145 in src/components/MoneyRequestConfirmationList.tsx

View workflow job for this annotation

GitHub Actions / ESLint check 

React Hook useCallback has a missing dependency: 'isNewManualExpenseFlowEnabled'. Either include it or remove the dependency array
routeError,
transactionID,
iouType,
Expand Down
Loading