Skip to content

Add Assign new cards option for direct card feeds v2#86032

Draft
fedirjh wants to merge 12 commits intoExpensify:mainfrom
fedirjh:sync-feed-cards
Draft

Add Assign new cards option for direct card feeds v2#86032
fedirjh wants to merge 12 commits intoExpensify:mainfrom
fedirjh:sync-feed-cards

Conversation

@fedirjh
Copy link
Contributor

@fedirjh fedirjh commented Mar 22, 2026

Explanation of Change

Direct card feeds cache their accountList at initial connection. When banks issue new cards, they don't appear in NewDot's assignment UI. This PR adds an "Assign new cards" menu item in the feed settings page (only for direct feeds) that triggers the existing OAuth/Plaid reconnection flow to refresh the card list.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/594594
$ #79383
$ #85676
PROPOSAL:

Tests

  1. Navigate to a workspace with a direct (OAuth) card feed
  2. Go to Settings for that feed
  3. Verify "Assign new cards" menu item appears with the Sync icon and the description "Get the latest cards to assign from your bank"
  4. Tap "Assign new cards" → verify bank auth opens
  5. Complete re-auth → verify modal dismisses
  6. Navigate to a workspace with a commercial card feed → Settings → verify "Assign new cards" does NOT appear
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Navigate to feed settings → tap "Assign new cards"
  3. Verify the offline blocking view is shown
  4. Go back online → verify the flow resumes

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  1. Navigate to a workspace with a direct card feed → Settings
  2. Verify "Assign new cards" appears only for direct feeds (OAuth/Plaid)
  3. Tap "Assign new cards" and complete re-auth
  4. Verify modal dismisses after re-auth
  5. Verify no errors in the JS console
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

fedirjh added 6 commits March 21, 2026 22:09
@fedirjh
Add refresh card feed connection route and screen
ec123a9 
- Introduced a new route for refreshing the company card feed connection in ROUTES.ts.
- Added corresponding screen identifier in SCREENS.ts.
- Updated navigation types to include parameters for the new screen.
- Registered the new screen in the modal stack navigator.
- Updated linking configuration to support the new route.
@fedirjh
Add translations for assigning new cards in English and Spanish
2f3cfa1 
- Added new translation keys for 'Assign new cards' and its description in both en.ts and es.ts files.
@fedirjh
Add RefreshCardFeedConnectionPage and integrate with WorkspaceCompany…
f040967 
…CardsSettingsPage

- Created a new RefreshCardFeedConnectionPage component to handle the card feed connection process.
- Implemented logic to manage navigation based on the current step of the card assignment process.
- Updated WorkspaceCompanyCardsSettingsPage to include a menu item for assigning new cards, linking it to the new refresh card feed connection page.
- Enhanced the user experience by conditionally displaying the new menu item based on the feed type.
@fedirjh
Enhance card assignment flow with refresh state management
577e492 
- Updated the AssignCard type to include an isRefreshing property to track the refresh state.
- Modified setAssignCardStepAndData function to accept and merge the isRefreshing state.
- Implemented logic in RefreshCardFeedConnectionPage to prevent navigation during refresh.
- Adjusted WorkspaceCompanyCardsSettingsPage to set the isRefreshing state when initiating card assignment.
@fedirjh
Refactor RefreshCardFeedConnectionPage to improve refresh state handling
a6a1eec 
- Introduced usePrevious hook to track the previous isRefreshing state.
- Updated navigation logic to close the RHP flow only when transitioning from refreshing to not refreshing.
- Adjusted useEffect dependencies for better state management.
@fedirjh
Enhance card connection components with title prop support
f591523 
- Added a title prop to BankConnection and PlaidConnectionStep components for better header customization.
- Updated RefreshCardFeedConnectionPage to utilize the new title prop, improving consistency in header titles across components.
- Refactored LoadingPage to use the title prop for a unified user experience.
@melvin-bot
Copy link

melvin-bot bot commented Mar 22, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

fedirjh added 6 commits March 22, 2026 02:10
@fedirjh
Enhance RefreshCardFeedConnectionPage with feed expiration handling
3f800d3 
- Integrated useCardFeeds hook to manage card feed data and expiration.
- Added logic to trigger setFeedRefreshComplete on feed expiration changes during refresh.
- Improved state management in RefreshCardFeedConnectionPage for better user experience.
- Refactored imports in WorkspaceCompanyCardsSettingsPage for clarity and organization.
@fedirjh
Add unit tests for RefreshCardFeedConnectionPage
5172537 
- Created comprehensive tests for the RefreshCardFeedConnectionPage component to validate rendering based on different states.
- Included tests for loading state, bank connection, and plaid connection steps.
- Verified that the correct actions are called on component unmount and when feed expiration updates.
- Enhanced test coverage to ensure robust handling of card feed connection scenarios.
@fedirjh
Add WorkspaceCompanyCardsVerifyAccountPage and related routing logic
5a684b3 
- Introduced a new page for verifying company card accounts, enhancing the user flow for account validation.
- Updated ROUTES.ts and SCREENS.ts to include the new verification route and screen identifier.
- Modified navigation logic in existing components to redirect users to the verification page when account validation is required.
- Ensured proper linking configuration for the new route to maintain navigation integrity.
@fedirjh
Enhance company card feed functionality with new refresh logic
1c588a4 
- Introduced seedCardFeedRefresh and startCardFeedRefresh functions to manage the card feed refresh flow.
- Updated WorkspaceCompanyCardsVerifyAccountPage to utilize the new refresh logic upon successful account validation.
- Refactored WorkspaceCompanyCardsSettingsPage to initiate the card feed refresh process using the new functions.
- Improved import organization across multiple components for better clarity and maintainability.
@fedirjh
Refactor RefreshCardFeedConnectionPage and WorkspaceCompanyCardsSetti…
1dfd79a 
…ngsPage for improved state handling

- Updated RefreshCardFeedConnectionPage to enhance the logic for closing the RHP flow and setting feed refresh completion based on state changes.
- Refactored useEffect dependencies to prevent unnecessary executions and improve clarity.
- Moved the import statement for isUserValidatedSelector in WorkspaceCompanyCardsSettingsPage for better organization.
@fedirjh
Refactor imports and enhance test structure for RefreshCardFeedConnec…
f7fb565 
…tionPage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fedirjh fedirjh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fedirjh