[No QA] Revise language for clarity in Submit plan documentation#85933
[No QA] Revise language for clarity in Submit plan documentation#85933garrettmknight wants to merge 3 commits intomainfrom
Conversation
Updated wording for clarity and consistency throughout the document, including details on workspace creation, submission processes, and member permissions.
|
|
||
| Your manager will receive an email with a link to review the report. | ||
|
|
||
| [ADD IMAGE OF SUBMIT POPOVER] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 666dad18b0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
docs/articles/new-expensify/getting-started/Create-a-Workspace-on-the-Submit-Plan.md
Show resolved
Hide resolved
Added images to enhance the guide on creating a workspace.
Updated instructions for tracking reimbursement status outside of Expensify, replacing 'Mark as paid' with 'More > Payment received'.
|
@stephanieelliott no rush on this one, feature is still in detailed, just mapping comms out. |
|
|
||
| ## Create a Submit workspace during onboarding | ||
|
|
||
| If you’re new to Expensify, you can create a Submit workspace during setup. |
There was a problem hiding this comment.
AI readiness / Missing "How to" heading: Per HELP_AUTHORING_GUIDELINES.md Section 6, every article must include at least one full "How to..." heading using the feature name. None of the ## headings in this article use "How to..." phrasing.
Consider renaming this heading (or another primary heading) to include "How to" -- for example:
## How to create a Submit workspace during onboarding
This improves semantic retrieval and matches real user search queries.
| 3. Choose to create a new workspace (if you don’t join an existing one). | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Screenshot format violation: Per HELP_AUTHORING_GUIDELINES.md Section 8, screenshots must use HTML comment placeholders so they are invisible in the rendered article. Inline Markdown images () are not permitted.
Replace with:
|
|
||
| If you already have an account, you can create a Submit workspace at any time. | ||
|
|
||
| 1. Go to the pricing page at https://www.expensify.com/pricing |
There was a problem hiding this comment.
Cross-linking violation: Per HELP_AUTHORING_GUIDELINES.md Section 7, articles must use relative links only. Full URLs (like https://www.expensify.com/pricing) are not permitted. Additionally, links should not be placed inside numbered step instructions.
Consider restructuring so the URL reference is outside the numbered steps, and use a relative link if possible.
| --- | ||
|
|
||
| ## Set up your Submit workspace | ||
|
|
There was a problem hiding this comment.
Readability / structure: Per TEMPLATE.md, articles should include a ## Who can use [exact feature name] section that states the required role, plan limitations, and permission prerequisites. This article is missing that section.
Consider adding a section such as:
## Who can use the Submit planThis section should clarify that any Expensify user can create a Submit workspace, the plan is free, and what roles/permissions apply.
|
|
||
| If your manager reimburses you outside of Expensify, you can track it manually. | ||
|
|
||
| 1. Open a submitted report |
There was a problem hiding this comment.
Naming and style / Three dots menu rule: Per HELPSITE_NAMING_CONVENTIONS.md, you must never refer to the menu as "More". The required phrasing is:
Select the three dots (⋮)
Replace this line with:
2. Select the three dots **(⋮)** and then select **Payment received**|
|
||
| 1. Open a submitted report | ||
| 2. Click **More** > **Payment received** | ||
|
|
There was a problem hiding this comment.
Screenshot format violation + Typo: Two issues on this line:
- Per HELP_AUTHORING_GUIDELINES.md Section 8, screenshots must use HTML comment placeholders, not inline Markdown images.
- The alt text contains a typo: "Paymemt" should be "Payment".
Replace with:
| 1. Click **Upgrade** when prompted | ||
| 2. Confirm the upgrade | ||
|
|
||
| Upgrading: |
There was a problem hiding this comment.
Naming and style violation: Per HELPSITE_NAMING_CONVENTIONS.md, all button names must be bolded using bold formatting. "Confirm" here appears to reference a button action but is not bolded.
| Upgrading: | |
| 2. Click **Confirm** to upgrade |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new documentation article for creating a workspace on the Submit plan. The article is well-organized, covers a clear user workflow, and is written in a helpful, approachable tone. However, several governance rule violations need to be addressed before merging -- most notably the missing "How to..." heading, incorrect three-dot menu reference, inline images instead of screenshot placeholders, a full URL instead of a relative link, and an Scores Summary
Key FindingsMust fix:
Should fix: Positive aspects:
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://f67b06f0.helpdot.pages.dev ⚡️ Updated articles: |



Updated wording for clarity and consistency throughout the document, including details on workspace creation, submission processes, and member permissions.
Explanation of Change
Fixed Issues
$https://github.com/Expensify/Expensify/issues/613373
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari