Refractor duplicate and delete expense articles #85893
Refractor duplicate and delete expense articles #85893stephanieelliott wants to merge 5 commits intomainfrom
Conversation
…lagged-Duplicate-Expenses.md
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ## How to Find Duplicate Expenses in the Inbox Using the Red Dot Indicator | ||
|
|
||
| 1. In the navigation tabs (on the left on web and at the bottom on mobile), select **Inbox**. | ||
| 2. Look for chats with a red dot. |
There was a problem hiding this comment.
Navigation phrasing violation: The standard navigation phrasing defined in HELPSITE_NAMING_CONVENTIONS.md is: "on the left on web**,** on the bottom on mobile" (comma separator, and "on the bottom" not "at the bottom").
This line uses "and" instead of a comma and "at the bottom" instead of "on the bottom".
| 2. Look for chats with a red dot. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Inbox**. |
| Design request:https://github.com/Expensify/Expensify/issues/614048 | ||
| --> | ||
|
|
||
| --- |
There was a problem hiding this comment.
Screenshot placeholder format violation: Per HELP_AUTHORING_GUIDELINES.md Section 8, screenshot placeholders must include all three required fields: Suggestion, Location, and Purpose. This placeholder is missing Location: and Purpose:, and uses a non-standard Design request: field instead.
Expected format:
| <!-- SCREENSHOT: | ||
| Suggestion: Show expense with Review Duplicates at the top | ||
| Design request:https://github.com/Expensify/Expensify/issues/614048 | ||
| --> |
There was a problem hiding this comment.
Screenshot placeholder format violation: Same issue as the first placeholder -- missing required Location: and Purpose: fields per HELP_AUTHORING_GUIDELINES.md Section 8. The Design request: field is non-standard.
Expected format:
|
|
||
| --- | ||
|
|
||
| ## Who Can Use Duplicate Detection |
There was a problem hiding this comment.
Heading case violation: All governance examples and the TEMPLATE.md use sentence case for headings (e.g., ## Who can use [exact feature name], ## How to troubleshoot bank connection errors). This heading uses Title Case.
| ## Who Can Use Duplicate Detection | |
| ## Who can use duplicate detection |
| --- | ||
|
|
||
| ## How to Find Duplicate Expenses in the Inbox Using the Red Dot Indicator | ||
|
|
There was a problem hiding this comment.
Heading case violation: Per governance examples, headings should use sentence case, not Title Case. Additionally, this heading is quite long -- consider whether it can be shortened while remaining task-based and searchable.
| ## How to find duplicate expenses in the Inbox using the red dot indicator |
|
|
||
| ## How to Resolve a Flagged Duplicate Expense | ||
|
|
||
| 1. Open the report or chat with the red dot. |
There was a problem hiding this comment.
Heading case violation: Per governance examples in HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md, headings should use sentence case.
| 1. Open the report or chat with the red dot. | |
| ## How to resolve a flagged duplicate expense |
| --> | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Heading case violation: Per governance examples and TEMPLATE.md (## What happens after you [complete primary task]), headings should use sentence case.
| ## What happens after you resolve a flagged duplicate |
| title: How to Find and Resolve Flagged Duplicate Expenses | ||
| description: Learn how Expensify detects duplicate expenses and how to resolve them when they are flagged and placed on hold. | ||
| keywords: [New Expensify, duplicate expense, review duplicates, expense on hold, resolve duplicate, flagged expense, red dot, duplicate detection, keep all, keep this one, held expense, Inbox red dot, find duplicate expenses, where to find duplicates] | ||
| internalScope: Audience is members and approvers on Collect or Control plans. Covers how to locate reports with duplicate expense violations and resolve flagged duplicates. Does not cover manually merging expenses or preventing duplicates. | ||
| --- | ||
|
|
||
| # How to Find and Resolve Flagged Duplicate Expenses |
There was a problem hiding this comment.
Heading case note: The YAML title and the # heading both use Title Case, but all governance examples in HELP_AUTHORING_GUIDELINES.md use sentence case for headings (e.g., # Who can connect a business bank account in Expensify). The TEMPLATE.md # heading rule states it must match the title exactly, so both need to be updated together if switching to sentence case.
Suggested title and heading:
title: How to find and resolve flagged duplicate expenses# How to find and resolve flagged duplicate expenses
|
|
||
| **Note:** Duplicate detection is available on Collect and Control plans only. | ||
|
|
||
| If you have two expenses that were not automatically flagged but should be combined, you can [learn how to merge them manually](/articles/new-expensify/reports-and-expenses/Merging-expenses). |
There was a problem hiding this comment.
Cross-link target may not exist: This links to /articles/new-expensify/reports-and-expenses/Merging-expenses, but please verify this article exists. If it does not, this link will result in a 404. Per HELP_AUTHORING_GUIDELINES.md Section 7, cross-links should only reference existing articles.
HelpDot Documentation ReviewOverall AssessmentThis PR replaces the old Scores Summary
Key FindingsPositive aspects:
Issues to address:
Recommendations
Files Reviewed
Note: This review is based solely on the proposed changes in the PR diff, evaluated against the HelpDot governance files (HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 117e46e0d2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| --- | ||
| title: How to Find and Resolve Flagged Duplicate Expenses | ||
| description: Learn how Expensify detects duplicate expenses and how to resolve them when they are flagged and placed on hold. | ||
| keywords: [New Expensify, duplicate expense, review duplicates, expense on hold, resolve duplicate, flagged expense, red dot, duplicate detection, keep all, keep this one, held expense, Inbox red dot, find duplicate expenses, where to find duplicates] | ||
| internalScope: Audience is members and approvers on Collect or Control plans. Covers how to locate reports with duplicate expense violations and resolve flagged duplicates. Does not cover manually merging expenses or preventing duplicates. |
There was a problem hiding this comment.
This rename deletes Duplicate-Detection.md without updating docs/redirects.csv, which still routes legacy aliases to /articles/new-expensify/reports-and-expenses/Duplicate-Detection (see lines 729 and 864-865 in the current file). Because HelpDot URLs are derived from the markdown filename, existing bookmarks and any inbound links to the old slug will now land on a 404 until the old slug redirects to How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.
Useful? React with 👍 / 👎.
stephanieelliott
changed the title
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot can you run |
MelvinBot
left a comment
MelvinBot
left a comment
There was a problem hiding this comment.
HelpDot Documentation Review (Re-run)
I've reviewed all four new articles against the HelpDot authoring guidelines. Here's a summary of the issues found across the files:
Issues by Category
| Category | Files Affected | Severity |
|---|---|---|
| Heading case (Title Case → sentence case) | 3 of 4 files | High — affects all # and ## headings |
| Cross-links use full URLs instead of relative | All 4 files | High — violates Section 7 |
| Cross-links point to deleted file slugs | 3 of 4 files | High — will produce 404s |
| Navigation phrasing deviations | All 4 files | Medium |
| Screenshot placeholder format | 2 of 2 files with placeholders | Low |
Per-File Summary
How-to-Delete-Expenses.md ✅ Good: Headings correctly use sentence case. Issues: Navigation uses capitalized "Web"/"Mobile" (should be lowercase), all cross-links use full URLs, one link points to the deleted Delete-Expenses slug (self-reference).
How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md — All headings use Title Case instead of sentence case. Navigation missing comma separator and uses "at the bottom" instead of "on the bottom". Screenshot placeholders missing Location: and Purpose: fields. Cross-link to Merging-expenses will break (file deleted in this PR).
How-to-Merge-Expenses.md — All headings use Title Case. Three cross-links use full URLs with incorrect paths (missing reports-and-expenses/ hub). Navigation uses "at the bottom" in all three instances. All three screenshot placeholders missing required fields.
Why-Expenses-Duplicate.md — All headings use Title Case. Six cross-links use full URLs, two of which point to the deleted Delete-Expenses slug. Missing --- separator before the "What to do" section. One slug has a casing mismatch (How-to-merge-expenses vs. How-to-Merge-Expenses).
What Improved Since Last Review
- ✅
How-to-Delete-Expenses.mdheadings are now in proper sentence case - ✅ Articles include
internalScopemetadata field - ✅ Single workflow per article is well maintained
- ✅ Cross-link anchor text is descriptive (no "click here")
- ✅ FAQ sections follow proper structure
See inline comments for specific line-level suggestions.
| internalScope: Audience is members and approvers on Collect or Control plans. Covers how to locate reports with duplicate expense violations and resolve flagged duplicates. Does not cover manually merging expenses or preventing duplicates. | ||
| --- | ||
|
|
||
| # How to Find and Resolve Flagged Duplicate Expenses |
There was a problem hiding this comment.
Heading case violation: Per HELP_AUTHORING_GUIDELINES.md and TEMPLATE.md governance examples, all headings should use sentence case (e.g., # How to find and resolve flagged duplicate expenses). This applies to the title: in YAML metadata as well. Title Case is used throughout this file — please convert all # and ## headings to sentence case.
| # How to Find and Resolve Flagged Duplicate Expenses | |
| # How to find and resolve flagged duplicate expenses |
|
|
||
| --- | ||
|
|
||
| ## Who Can Use Duplicate Detection |
There was a problem hiding this comment.
Heading case violation: Should use sentence case.
| ## Who Can Use Duplicate Detection | |
| ## Who can use duplicate detection |
|
|
||
| --- | ||
|
|
||
| ## How to Find Duplicate Expenses in the Inbox Using the Red Dot Indicator |
There was a problem hiding this comment.
Heading case violation: Should use sentence case. This heading is also quite long — consider shortening while keeping it task-based and searchable.
| ## How to Find Duplicate Expenses in the Inbox Using the Red Dot Indicator | |
| ## How to find duplicate expenses using the red dot indicator |
|
|
||
| ## How to Find Duplicate Expenses in the Inbox Using the Red Dot Indicator | ||
|
|
||
| 1. In the navigation tabs (on the left on web and at the bottom on mobile), select **Inbox**. |
There was a problem hiding this comment.
Navigation phrasing violation: The standard phrasing defined in HELPSITE_NAMING_CONVENTIONS.md is: "on the left on web**,** on the bottom on mobile" (comma separator, "on the bottom" not "at the bottom", and no "and").
| 1. In the navigation tabs (on the left on web and at the bottom on mobile), select **Inbox**. | |
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), select **Inbox**. |
|
|
||
| **Note:** Duplicate detection is available on Collect and Control plans only. | ||
|
|
||
| If you have two expenses that were not automatically flagged but should be combined, you can [learn how to merge them manually](/articles/new-expensify/reports-and-expenses/Merging-expenses). |
There was a problem hiding this comment.
Cross-link target will break: This links to /articles/new-expensify/reports-and-expenses/Merging-expenses, but that file is being deleted in this PR and replaced by How-to-Merge-Expenses.md. Update this link to the new slug.
| If you have two expenses that were not automatically flagged but should be combined, you can [learn how to merge them manually](/articles/new-expensify/reports-and-expenses/Merging-expenses). | |
| If you have two expenses that were not automatically flagged but should be combined, you can [learn how to merge them manually](/articles/new-expensify/reports-and-expenses/How-to-Merge-Expenses). |
| In some cases, duplicate expenses occur when the same card transaction is imported more than once. | ||
|
|
||
| This most often happens when a card connection is reconnected using a Transaction Start Date that is earlier than the last imported transaction. When this happens, Expensify imports older transactions again, even if they were already imported. | ||
|
|
There was a problem hiding this comment.
Multiple cross-links use full URLs and some point to deleted files: Lines 74–83 contain several full URLs that should be relative links. The links to Delete-Expenses (lines 82–83) point to a file being deleted in this PR — update to the new slug How-to-Delete-Expenses.
Suggested fix:
- [How to find and resolve flagged duplicate expenses](/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses)
- [How to merge duplicate expenses](/articles/new-expensify/reports-and-expenses/How-to-Merge-Expenses)
If both expenses are card transactions, they cannot be merged. Instead, [delete the duplicate expense](/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses) or [move the duplicate to your personal space](/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses#deleting-company-card-expenses).| 1. Open the expense you want to delete. | ||
| 2. From the expense, choose **More**. | ||
| 3. Choose **Delete**. | ||
|
|
There was a problem hiding this comment.
Navigation capitalization: Per HELPSITE_NAMING_CONVENTIONS.md, the standard phrasing uses lowercase "web" and "mobile". This applies to all navigation instructions in this file (lines 21, 31, 77, 87).
| 1. In the navigation tabs (on the left on web, on the bottom on mobile) select **Reports** > **Expenses**. |
|
|
||
| ## How to delete an expense from a report | ||
|
|
||
| 1. In the navigation tabs (on the left on Web, on the bottom on Mobile) select **Reports** > **Expenses**. |
There was a problem hiding this comment.
Cross-link uses full URL: Per HELP_AUTHORING_GUIDELINES.md Section 7, use relative links only.
| 1. In the navigation tabs (on the left on Web, on the bottom on Mobile) select **Reports** > **Expenses**. | |
| **Note:** You can only delete expenses from your own Unreported, Draft, and Outstanding reports. If the report is Approved, Done or Paid, it will need to be retracted first before deleting the expense. [Learn how to retract a report](/articles/new-expensify/reports-and-expenses/Edit-Expense-Reports). |
| - The expense was created by you. | ||
| - The expense is a manual cash expense, distance expense, or SmartScanned receipt. | ||
| - The expense is Unreported or on a Draft or Outstanding report. | ||
|
|
There was a problem hiding this comment.
Cross-link uses full URL and points to deleted file: This links to Delete-Expenses which is being deleted in this PR. Since this IS the replacement article, this appears to be a self-referencing link. If the intent is to link to a section within this same article, use an anchor link instead (e.g., #why-you-cant-delete-an-expense). Also, use relative links per HELP_AUTHORING_GUIDELINES.md Section 7.
|
|
||
| --- | ||
|
|
||
| # FAQ |
There was a problem hiding this comment.
Cross-link uses full URL: Use a relative link.
| # FAQ | |
| If you need access to another member's expenses, ask them to [add you as a Copilot](/articles/new-expensify/settings/Copilot-Access). This allows you to manage expenses on their behalf. |
2 participants
https://github.com/Expensify/Expensify/issues/612562