Restore zIndex on progress bar container to fix onboarding modal centering#85880
Restore zIndex on progress bar container to fix onboarding modal centering#85880
Conversation
…dal centering The onboarding modal is aligned to the top instead of being centered on web. PR #80460 replaced zIndex: -1 with pointerEvents: 'none' on the headerProgressBarContainer style. This removed the stacking context that kept the absolutely positioned progress bar behind other content, which affects the flex layout height computation on web browsers and breaks the vertical centering of the onboarding modal. Restoring zIndex: -1 alongside pointerEvents: 'none' preserves both the accessibility fix (pointer events pass through) and the correct stacking context needed for proper centering. Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>
|
The failing check Analysis: The Android build fails at the Gradle settings evaluation phase with: This is a CI dependency installation issue — the Evidence: Other Android build variants on this same run ( Recommendation: Re-run the failing check — this should resolve itself on a fresh CI run. |
|
The failing checks are unrelated to this PR's changes. Analysis: This PR only modifies
Evidence: The same All code-related checks pass: ESLint, typecheck, all 8 test jobs, prettier, storybook, spellcheck, and perf-tests. |
Explanation of Change
PR #80460 changed the
headerProgressBarContainerstyle fromzIndex: -1topointerEvents: 'none'. WhilepointerEvents: 'none'correctly prevents the progress bar from intercepting interactions, removingzIndex: -1changed the stacking context for the absolutely positioned progress bar container on web browsers. This affected the flex layout height computation of parent containers, causing the onboarding modal to align to the top of the screen instead of being vertically centered.This PR restores
zIndex: -1alongsidepointerEvents: 'none'so both the accessibility fix and the correct stacking context are preserved.Fixed Issues
$ #85872
PROPOSAL: #85872 (comment)
Tests
Offline tests
N/A — this is a CSS-only change that doesn't involve network requests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — CSS-only change, web platforms only
Android: mWeb Chrome
N/A — CSS-only change, web platforms only
iOS: Native
N/A — CSS-only change, web platforms only
iOS: mWeb Safari
N/A — CSS-only change, web platforms only
MacOS: Chrome / Safari