Skip to content

[CP Staging] Revert "[No QA] Fix lost/duplicated requests in PersistedRequests (Issues 2, 3, 4, 5)"#85804

Merged
mountiny merged 1 commit intomainfrom
revert-84622-callstack-internal/szymonzalarski/investigate-and-fix-sequential-queue-issues-issue-4
Mar 19, 2026
Merged

[CP Staging] Revert "[No QA] Fix lost/duplicated requests in PersistedRequests (Issues 2, 3, 4, 5)"#85804
mountiny merged 1 commit intomainfrom
revert-84622-callstack-internal/szymonzalarski/investigate-and-fix-sequential-queue-issues-issue-4

Conversation

@mountiny
Copy link
Contributor

Reverts #84622

Fixed issues

$ #85755
$ #85708
$ #85671
$ #85673
$ #85669

@mountiny mountiny self-assigned this Mar 19, 2026
@mountiny mountiny requested review from a team as code owners March 19, 2026 13:06
@melvin-bot melvin-bot bot requested review from ZhenjaHorbach and removed request for a team March 19, 2026 13:07
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team March 19, 2026 13:07
@ZhenjaHorbach
Copy link
Contributor

Do we need a review here?

@mountiny mountiny merged commit 7b1c20f into main Mar 19, 2026
31 of 37 checks passed
@melvin-bot melvin-bot bot added the Emergency label Mar 19, 2026
@mountiny mountiny deleted the revert-84622-callstack-internal/szymonzalarski/investigate-and-fix-sequential-queue-issues-issue-4 branch March 19, 2026 13:11
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Mar 19, 2026
…nal/szymonzalarski/investigate-and-fix-sequential-queue-issues-issue-4

[CP Staging] Revert "[No QA] Fix lost/duplicated requests in PersistedRequests (Issues 2, 3, 4, 5)"

(cherry picked from commit 7b1c20f)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 19, 2026
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85804.

Android 🤖 iOS 🍎
❌ FAILED ❌ ❌ FAILED ❌
The QR code can't be generated, because the Android build failed The QR code can't be generated, because the iOS build failed
Web 🕸️
https://85804.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/API/index.ts 92.78% <100.00%> (ø)
src/libs/Network/SequentialQueue.ts 86.55% <90.90%> (-0.06%) ⬇️
src/libs/actions/PersistedRequests.ts 85.10% <92.85%> (+7.94%) ⬆️
... and 9 files with indirect coverage changes

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants