-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Part 1] Onyx.connect() removal for ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in ReportUtils.ts #79822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ALUE_PAIRS in ReportUtils.ts
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx
Outdated
Show resolved
Hide resolved
src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx
Outdated
Show resolved
Hide resolved
src/pages/OnboardingWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx
Outdated
Show resolved
Hide resolved
src/pages/OnboardingWorkspaceOptional/BaseOnboardingWorkspaceOptional.tsx
Outdated
Show resolved
Hide resolved
|
@ShridharGoel Could you add test step? |
|
Added |
Explanation of Change
This change aims to pass archived state from Onyx hooks, so we can later delete the Onyx.connect() based fetch of report name value pairs. It updates the archived‑report lookups in navigation/onboarding.
Fixed Issues
$ #66422
PROPOSAL:
Tests
#adminsand the tasks should show.Offline tests
QA Steps
Same.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-20.at.12.37.02.AM.mov
Screen.Recording.2026-01-20.at.12.37.53.AM.mov