Follow up improvements for inline code blocks on native devices

[QichenZhu]

Explanation of Change

This implements step 1 on iOS of the 3-step incremental approach:

1. Add rounded corners like 'expense-report' below (if we can only get this far, it's already an improvement)

2. Add paddings like the 'Outstanding' badge below (this would be even better)

3. Add borders to match the web inline code block below (ideal)

Fixed Issues

$ #57556
PROPOSAL:

Tests

Note: This change only affects iOS Native.

1. Open any chat.
2. Send a message containing inline code blocks.
3. Verify that the inline code blocks are displayed with rounded corners on iOS.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native (N/A)

Android: mWeb Chrome (N/A)

iOS: Native

iOS: mWeb Safari (N/A)

MacOS: Chrome / Safari (N/A)

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[dubielzyk-expensify]

Looks like we're missing the border on the code blocks?

[dubielzyk-expensify]

Oh sorry. I see that you wanna split these up. Ignore me.

[shawnborton]

Looks like a good first step! Can you show a before/after screenshot too for easy comparison of the changes?

[QichenZhu]

@dubielzyk-expensify @shawnborton, thanks for your review.

Below shows before and after comparisons. A couple things to note:

1. Line spacing can be adjusted. It's 0px before and 2px after.

Before	After

2. Rounded corners only on the start and end of each code block, not on line breaks inside. This is also adjustable.

Before
After

[shawnborton]

Awesome, this is looking good to me 👍

Can you show some examples that use letters with descenders, like g or y? As well as more capital letters too? Just want to check how the background color is looking with different letterforms.

[QichenZhu]

Can you show some examples that use letters with descenders, like g or y? As well as more capital letters too?

Sure! How do these look?

Before
After

[shawnborton]

Okay cool, so it feels like we generally have more background color above the letterforms than below. Is there a way to shift things around where we drop the bg color down by a pixel? Like if the top had a margin of 3px, but the bottom had a margin of 1px instead of 2px on both. Let me know if that makes sense.

[QichenZhu]

Like if the top had a margin of 3px, but the bottom had a margin of 1px instead of 2px on both. Let me know if that makes sense.

Yeah, that makes sense. Below shows top 1px/bottom 1px (the After version in my previous comment), top 1.5px/bottom 0.5px (which are 3px and 1px on Retina screens), and top 2px/bottom 0px.

Top/bottom	Screenshot
1/1
1.5/0.5
2/0

[shawnborton]

The last option there feels the best to me, where we basically have capital letters perfectly centered within the space. cc @Expensify/design for a gut check on that though.

[dannymcclain]

Yup I'm with you - bottom option is looking pretty good!

[dubielzyk-expensify]

It doesn't look perfectly centered in the container to me?

[shawnborton]

Fair shout, @QichenZhu can we center it even more?

[QichenZhu]

Thanks for your patience. How does the version below look?

[shawnborton]

That seems pretty good to me. Lowercase letters will always feel like they sit slightly down, but I think that's fine. Let's roll with it and see how it feels.

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13ef88ee82

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Guard custom attribute array against nil background colors

This branch can execute when opacity is set even if backgroundColor is missing (if (textAttributes.backgroundColor || !isnan(textAttributes.opacity))), and in that case bgColor may be nil; constructing @[@(textAttributes.borderTopLeftRadius), bgColor] with a nil element raises an Objective-C exception and can crash iOS text rendering for styles that combine borderTopLeftRadius and opacity without a background color. Please guard bgColor before creating the array (or fall back to the existing background-color path).

Useful? React with 👍 / 👎.

[QichenZhu]

Hi @rojiphil, could you review this when you get a chance?

[QichenZhu]

@rojiphil, this is ready for your review.

[QichenZhu]

@rojiphil, this PR is prone to conflicts but they won't affect the review. I'll resolve them weekly or on request. Thanks!

[rojiphil]

@QichenZhu I tested the PR but I am unable to see the rounded corners. Am I missing something here?

79815-ios-standalone-001.mp4

[QichenZhu]

@rojiphil it could be the remote cache. Could you try rebuilding the iOS app locally or requesting an ad hoc build?

[QichenZhu]

Hi @rojiphil, how's the review going? Were you able to rebuild locally or request an ad hoc build?