feat: Add per-feature-view metrics for online read path#365
Open
vanitabhagwat wants to merge 2 commits into
Open
feat: Add per-feature-view metrics for online read path#365vanitabhagwat wants to merge 2 commits into
vanitabhagwat wants to merge 2 commits into
Conversation
…uests, errors, hit rate) Emit per-feature-view latency, request count, error count, and total lookup requests on every online read in the Go feature server (HTTP + gRPC). This enables per-FV hit-rate computation in Datadog and allows filtering latency/error distributions by feature view. Key changes: - Add Distribution() to StatsdClient interface - New FeatureViewReadMetrics emitter (fv_read_latency_ms, fv_read_requests, fv_read_errors) - Extend LookupMetricsAggregator with totalByFV for feature_lookup_requests - Extract FV names from request (works with fullFeatureNames=false) - New unified flag ENABLE_FV_LEVEL_METRICS (backward compat with ENABLE_MISSING_KEY_METRICS) - Instrument GetOnlineFeatures and GetOnlineFeaturesRange in both HTTP and gRPC handlers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… emission - Define constants for all metric names (FVReadLatencyMetric, FVReadRequestsMetric, FVReadErrorsMetric, LookupNotFoundMetric, LookupNullOrExpiredMetric, LookupRequestsMetric) - Extract emitFVReadMetrics helper into server_commons.go to eliminate 4 identical nil-check + construct + emit patterns across HTTP and gRPC handlers - Update tests to reference constants instead of string literals Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vanitabhagwat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit per-feature-view latency, request count, error count, and total lookup requests on every online read in the Go feature server (HTTP + gRPC). This enables per-FV hit-rate computation in Datadog and allows filtering latency/error distributions by feature view.
Key changes:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc